Skip empty lines #89
Merged
Skip empty lines #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@e5l, could you please take a look? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue with the ReadBuffer functionality by properly skipping empty lines during input processing. The changes include:
- Updating ReadBuffer to return null for empty lines instead of an empty string.
- Adding a new test case to ensure the empty line behavior is correctly handled.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/jvmTest/kotlin/shared/ReadBufferTest.kt | Added a test to validate that an empty line returns null. |
| src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/shared/ReadBuffer.kt | Modified the empty line handling to return null after skipping the newline. |
Comments suppressed due to low confidence (1)
src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/shared/ReadBuffer.kt:27
- Changing from returning an empty string to null on an empty line fixes the issue reported with the ReadBuffer, but please ensure that this behavior is consistent with the overall contract of readMessage() and doesn’t cause side effects elsewhere.
return null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This pull request fixes an issue with the
ReadBufferfunctionality by ensuring that empty lines are properly skipped during input processing. A new test case has been added to validate this behavior.How Has This Been Tested?
The
ReadBufferthrew exception on empty message which leaded to connection closing.Breaking Changes
no
Types of changes
Checklist
Additional context