Skip to content

Commit d034136

Browse files
committed
Fix code review comments
1 parent 7364da4 commit d034136

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# MCP PHP SDK
22

3-
The official PHP SDK for Model Context Protocol (MCP). It provides a framework-agnostic API for implementing MCP servers in PHP. Maintained by Symfony and The PHP Foundation.
3+
The official PHP SDK for Model Context Protocol (MCP). It provides a framework-agnostic API for implementing MCP servers in PHP.
44

55
> [!IMPORTANT]
66
> Currently, we are still in the process of merging [Symfony's MCP SDK](https://github.com/symfony/mcp-sdk) and

src/Server/ServerBuilder.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -219,18 +219,18 @@ public function build(): Server
219219
$logger = $this->logger ?? new NullLogger();
220220

221221
$container = $this->container ?? new Container();
222-
$registry = new Registry(new ReferenceHandler($container), $this->eventDispatcher, $this->logger);
222+
$registry = new Registry(new ReferenceHandler($container), $this->eventDispatcher, $logger);
223223

224-
$this->registerManualElements($registry, $this->logger);
224+
$this->registerManualElements($registry, $logger);
225225

226226
if (null !== $this->discoveryBasePath) {
227-
$discovery = new Discoverer($registry, $this->logger);
227+
$discovery = new Discoverer($registry, $logger);
228228
$discovery->discover($this->discoveryBasePath, $this->discoveryScanDirs, $this->discoveryExcludeDirs);
229229
}
230230

231231
return new Server(
232-
Handler::make($registry, $this->serverInfo, $this->logger),
233-
$this->logger,
232+
Handler::make($registry, $this->serverInfo, $logger),
233+
$logger,
234234
);
235235
}
236236

0 commit comments

Comments
 (0)