Use generator to return notifications

Author: Bellangelo

src/Server/NotificationPublisher.php

@@ -45,17 +45,13 @@ public function enqueue(string $notificationType): void
     }
 
     /**
-     * @return iterable<Notification>
+     * @return \Generator<int, Notification, void, void>
      */
     public function flush(): iterable
     {
-        if (!$this->queue) {
-            return [];
-        }
-
         $out = $this->queue;
         $this->queue = [];
 
-        return $out;
+        yield from $out;
     }
 }

tests/Server/NotificationPublisherTest.php

@@ -38,14 +38,14 @@ public function testEnqueue(): void
             $notificationPublisher->enqueue($notificationType);
         }
 
-        $flushedNotifications = $notificationPublisher->flush();
+        $flushedNotifications = iterator_to_array($notificationPublisher->flush());
 
         $this->assertCount(\count($expectedNotifications), $flushedNotifications);
 
         foreach ($flushedNotifications as $index => $notification) {
             $this->assertInstanceOf($expectedNotifications[$index], $notification);
         }
 
-        $this->assertEmpty($notificationPublisher->flush());
+        $this->assertEmpty(iterator_to_array($notificationPublisher->flush()));
     }
 }