Skip to content

Commit 14e5b9b

Browse files
author
文徐
committed
remove SilentResponse
1 parent 635ffcb commit 14e5b9b

File tree

6 files changed

+11
-12
lines changed

6 files changed

+11
-12
lines changed

examples/servers/simple-prompt/mcp_simple_prompt/server.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,17 +77,17 @@ async def get_prompt(name: str, arguments: dict[str, str] | None = None) -> type
7777
)
7878

7979
if transport == "sse":
80-
from mcp.server.fastmcp.server import SilentResponse
8180
from mcp.server.sse import SseServerTransport
8281
from starlette.applications import Starlette
82+
from starlette.responses import Response
8383
from starlette.routing import Mount, Route
8484

8585
sse = SseServerTransport("/messages/")
8686

8787
async def handle_sse(request: Request):
8888
async with sse.connect_sse(request.scope, request.receive, request._send) as streams: # type: ignore[reportPrivateUsage]
8989
await app.run(streams[0], streams[1], app.create_initialization_options())
90-
return SilentResponse()
90+
return Response()
9191

9292
starlette_app = Starlette(
9393
debug=True,

examples/servers/simple-resource/mcp_simple_resource/server.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,17 +57,17 @@ async def read_resource(uri: AnyUrl) -> str | bytes:
5757
return SAMPLE_RESOURCES[name]["content"]
5858

5959
if transport == "sse":
60-
from mcp.server.fastmcp.server import SilentResponse
6160
from mcp.server.sse import SseServerTransport
6261
from starlette.applications import Starlette
62+
from starlette.responses import Response
6363
from starlette.routing import Mount, Route
6464

6565
sse = SseServerTransport("/messages/")
6666

6767
async def handle_sse(request: Request):
6868
async with sse.connect_sse(request.scope, request.receive, request._send) as streams: # type: ignore[reportPrivateUsage]
6969
await app.run(streams[0], streams[1], app.create_initialization_options())
70-
return SilentResponse()
70+
return Response()
7171

7272
starlette_app = Starlette(
7373
debug=True,

examples/servers/simple-tool/mcp_simple_tool/server.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,17 +58,17 @@ async def list_tools() -> list[types.Tool]:
5858
]
5959

6060
if transport == "sse":
61-
from mcp.server.fastmcp.server import SilentResponse
6261
from mcp.server.sse import SseServerTransport
6362
from starlette.applications import Starlette
63+
from starlette.responses import Response
6464
from starlette.routing import Mount, Route
6565

6666
sse = SseServerTransport("/messages/")
6767

6868
async def handle_sse(request: Request):
6969
async with sse.connect_sse(request.scope, request.receive, request._send) as streams: # type: ignore[reportPrivateUsage]
7070
await app.run(streams[0], streams[1], app.create_initialization_options())
71-
return SilentResponse()
71+
return Response()
7272

7373
starlette_app = Starlette(
7474
debug=True,

src/mcp/server/sse.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ async def handle_sse(request):
2323
streams[0], streams[1], app.create_initialization_options()
2424
)
2525
# Return empty response to avoid NoneType error
26-
return SilentResponse()
26+
return Response()
2727
2828
# Create and run Starlette app
2929
starlette_app = Starlette(routes=routes)

tests/server/test_sse_security.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010
import uvicorn
1111
from starlette.applications import Starlette
1212
from starlette.requests import Request
13+
from starlette.responses import Response
1314
from starlette.routing import Mount, Route
1415

1516
from mcp.server import Server
16-
from mcp.server.fastmcp.server import SilentResponse
1717
from mcp.server.sse import SseServerTransport
1818
from mcp.server.transport_security import TransportSecuritySettings
1919
from mcp.types import Tool
@@ -55,7 +55,7 @@ async def handle_sse(request: Request):
5555
except ValueError as e:
5656
# Validation error was already handled inside connect_sse
5757
logger.debug(f"SSE connection failed validation: {e}")
58-
return SilentResponse()
58+
return Response()
5959

6060
routes = [
6161
Route("/sse", endpoint=handle_sse),

tests/shared/test_sse.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
from mcp.client.session import ClientSession
2121
from mcp.client.sse import sse_client
2222
from mcp.server import Server
23-
from mcp.server.fastmcp.server import SilentResponse
2423
from mcp.server.sse import SseServerTransport
2524
from mcp.server.transport_security import TransportSecuritySettings
2625
from mcp.shared.exceptions import McpError
@@ -93,7 +92,7 @@ def make_server_app() -> Starlette:
9392
async def handle_sse(request: Request) -> Response:
9493
async with sse.connect_sse(request.scope, request.receive, request._send) as streams:
9594
await server.run(streams[0], streams[1], server.create_initialization_options())
96-
return SilentResponse()
95+
return Response()
9796

9897
app = Starlette(
9998
routes=[
@@ -356,7 +355,7 @@ def run_context_server(server_port: int) -> None:
356355
async def handle_sse(request: Request) -> Response:
357356
async with sse.connect_sse(request.scope, request.receive, request._send) as streams:
358357
await context_server.run(streams[0], streams[1], context_server.create_initialization_options())
359-
return SilentResponse()
358+
return Response()
360359

361360
app = Starlette(
362361
routes=[

0 commit comments

Comments
 (0)