fix

Author: dsp-ant

examples/clients/simple-chatbot/mcp_simple_chatbot/main.py

@@ -322,8 +322,7 @@ async def process_llm_response(self, llm_response: str) -> str:
                                 total = result["total"]
                                 percentage = (progress / total) * 100
                                 logging.info(
-                                    f"Progress: {progress}/{total} "
-                                    f"({percentage:.1f}%)"
+                                    f"Progress: {progress}/{total} ({percentage:.1f}%)"
                                 )
 
                             return f"Tool execution result: {result}"

pyproject.toml

@@ -43,7 +43,7 @@ mcp = "mcp.cli:app [cli]"
 [tool.uv]
 resolution = "lowest-direct"
 dev-dependencies = [
-    "pyright>=1.1.391",
+    "pyright>=1.1.396",
     "pytest>=8.3.4",
     "ruff>=0.8.5",
     "trio>=0.26.2",
@@ -70,9 +70,6 @@ strict = [
     "src/mcp/server/fastmcp/tools/base.py",
 ]
 
-[tool.pytest.ini_options]
-markers = ["anyio"]
-
 [tool.ruff.lint]
 select = ["E", "F", "I"]
 ignore = []
@@ -95,8 +92,12 @@ mcp = { workspace = true }
 xfail_strict = true
 filterwarnings = [
     "error",
+    # this is a long-standing issue with fastmcp, which is just now being exercised by tests
+    "ignore:Unclosed:ResourceWarning",
     # This should be fixed on Uvicorn's side.
     "ignore::DeprecationWarning:websockets",
     "ignore:websockets.server.WebSocketServerProtocol is deprecated:DeprecationWarning",
-    "ignore:Returning str or bytes.*:DeprecationWarning:mcp.server.lowlevel"
+    "ignore:Returning str or bytes.*:DeprecationWarning:mcp.server.lowlevel",
+    # this is a problem in starlette
+    "ignore:Please use `import python_multipart` instead.:PendingDeprecationWarning",
 ]

src/mcp/client/auth/oauth.py

@@ -385,15 +385,15 @@ async def open_user_agent(self, url: AnyHttpUrl) -> None:
         ...
 
     async def client_registration(
-        self, endpoint: AnyHttpUrl
+        self, issuer: AnyHttpUrl
     ) -> DynamicClientRegistration | None:
         """
         Loads the client registration for the given endpoint.
         """
         ...
 
     async def store_client_registration(
-        self, endpoint: AnyHttpUrl, metadata: DynamicClientRegistration
+        self, issuer: AnyHttpUrl, metadata: DynamicClientRegistration
     ) -> None:
         """
         Stores the client registration to be retreived for the next session

src/mcp/server/lowlevel/server.py

@@ -578,14 +578,12 @@ async def _handle_notification(self, notify: Any):
             assert type(notify) in self.notification_handlers
 
             handler = self.notification_handlers[type(notify)]
-            logger.debug(
-                f"Dispatching notification of type " f"{type(notify).__name__}"
-            )
+            logger.debug(f"Dispatching notification of type {type(notify).__name__}")
 
             try:
                 await handler(notify)
             except Exception as err:
-                logger.error(f"Uncaught exception in notification handler: " f"{err}")
+                logger.error(f"Uncaught exception in notification handler: {err}")
 
 
 async def _ping_handler(request: types.PingRequest) -> types.ServerResult:

src/mcp/server/sse.py

@@ -79,7 +79,6 @@ def __init__(self, endpoint: str) -> None:
         self._read_stream_writers = {}
         logger.debug(f"SseServerTransport initialized with endpoint: {endpoint}")
 
-    @deprecated("use connect_sse_v2 instead")
     @asynccontextmanager
     async def connect_sse(self, scope: Scope, receive: Receive, send: Send):
         if scope["type"] != "http":
@@ -130,11 +129,6 @@ async def sse_writer():
             tg.start_soon(response, scope, receive, send)
 
             logger.debug("Yielding read and write streams")
-            # TODO: hold on; shouldn't we be returning the EventSourceResponse?
-            # I think this is why the tests hang
-            # TODO: we probably shouldn't return response here, since it's a breaking
-            # change
-            # this is just to test
             yield (read_stream, write_stream, response)
 
     async def handle_post_message(

tests/client/test_oauth.py

@@ -6,6 +6,7 @@
 from pydantic import AnyHttpUrl
 
 from mcp.client.auth.oauth import (
+    AccessToken,
     ClientMetadata,
     DynamicClientRegistration,
     OAuthClient,
@@ -24,7 +25,30 @@ def client_metadata(self) -> ClientMetadata:
             response_types=["code"],
         )
 
-    def save_client_information(self, metadata: DynamicClientRegistration) -> None:
+    @property
+    def redirect_url(self) -> AnyHttpUrl:
+        return AnyHttpUrl("https://client.example.com/callback")
+
+    async def open_user_agent(self, url: AnyHttpUrl) -> None:
+        pass
+
+    async def client_registration(
+        self, issuer: AnyHttpUrl
+    ) -> DynamicClientRegistration | None:
+        return None
+
+    async def store_client_registration(
+        self, issuer: AnyHttpUrl, metadata: DynamicClientRegistration
+    ) -> None:
+        pass
+
+    def code_verifier(self) -> str:
+        return "test-code-verifier"
+
+    async def token(self) -> AccessToken | None:
+        return None
+
+    async def store_token(self, token: AccessToken) -> None:
         pass
 
 
@@ -229,8 +253,5 @@ def test_build_discovery_url_with_various_formats(input_url, expected_discovery_
     # Create auth client with the given URL
     auth_client = OAuthClient(AnyHttpUrl(input_url), MockOauthClientProvider())
 
-    # Call the method under test
-    discovery_url = auth_client._build_discovery_url()
-
     # Assertions
-    assert discovery_url == AnyHttpUrl(expected_discovery_url)
+    assert auth_client.discovery_url == AnyHttpUrl(expected_discovery_url)