Skip to content

Commit 502b628

Browse files
Ashishkjain-aisridharavinashdomdomegg
authored
fix: resolve registry image conflict in docker-compose (#114)
Issue: links directive was failing on podman - Removed unsupported 'links' directive for Podman compatibility <!-- Provide a brief summary of your changes --> It was failing on Podman because Podman doesn't support the links directive that Docker Compose does, and we already using depends_on, which establishes the dependency relationship between services; we can simply remove the links section from your docker-compose.yml file. ## Motivation and Context docker-compose -links deprecated #107 Fix the defect by removing link. ## How Has This Been Tested? Yes. Test by running on both. For Docker run. docker build -t registry . docker compose up For Podman podman build -t registry . podman compose up ## Breaking Changes Yes for podman. ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ x] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ x] My code follows the repository's style guidelines - [ x] New and existing tests pass locally - [ x] I have added appropriate error handling - [x ] I have added or updated documentation as needed ## Additional context It is related to issue #107 Co-authored-by: Avinash Sridhar <[email protected]> Co-authored-by: adam jones <[email protected]>
1 parent 26b85d7 commit 502b628

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

docker-compose.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ services:
44
container_name: registry
55
build:
66
dockerfile: Dockerfile
7-
links:
8-
- mongodb
97
depends_on:
108
- mongodb
119
environment:

0 commit comments

Comments
 (0)