fmt, add more tests

🏠 Remote-Dev: homespace

Author: domdomegg

internal/api/server_test.go

@@ -1,27 +1,29 @@
-package api
+package api_test
 
 import (
 	"net/http"
 	"net/http/httptest"
 	"testing"
+
+	"github.com/modelcontextprotocol/registry/internal/api"
 )
 
 func TestTrailingSlashMiddleware(t *testing.T) {
 	// Create a simple handler that returns "OK"
-	handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+	handler := http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 		w.WriteHeader(http.StatusOK)
-		w.Write([]byte("OK"))
+		_, _ = w.Write([]byte("OK"))
 	})
 
 	// Wrap with our middleware
-	middleware := TrailingSlashMiddleware(handler)
+	middleware := api.TrailingSlashMiddleware(handler)
 
 	tests := []struct {
-		name           string
-		path           string
-		expectedStatus int
+		name             string
+		path             string
+		expectedStatus   int
 		expectedLocation string
-		expectRedirect bool
+		expectRedirect   bool
 	}{
 		{
 			name:           "root path should not redirect",
@@ -36,31 +38,44 @@ func TestTrailingSlashMiddleware(t *testing.T) {
 			expectRedirect: false,
 		},
 		{
-			name:           "path with trailing slash should redirect",
-			path:           "/v0/servers/",
-			expectedStatus: http.StatusPermanentRedirect,
+			name:             "path with trailing slash should redirect",
+			path:             "/v0/servers/",
+			expectedStatus:   http.StatusPermanentRedirect,
 			expectedLocation: "/v0/servers",
-			expectRedirect: true,
+			expectRedirect:   true,
 		},
 		{
-			name:           "nested path with trailing slash should redirect",
-			path:           "/v0/servers/123/",
-			expectedStatus: http.StatusPermanentRedirect,
+			name:             "nested path with trailing slash should redirect",
+			path:             "/v0/servers/123/",
+			expectedStatus:   http.StatusPermanentRedirect,
 			expectedLocation: "/v0/servers/123",
-			expectRedirect: true,
+			expectRedirect:   true,
 		},
 		{
-			name:           "deep nested path with trailing slash should redirect", 
-			path:           "/v0/auth/github/token/",
-			expectedStatus: http.StatusPermanentRedirect,
+			name:             "deep nested path with trailing slash should redirect",
+			path:             "/v0/auth/github/token/",
+			expectedStatus:   http.StatusPermanentRedirect,
 			expectedLocation: "/v0/auth/github/token",
-			expectRedirect: true,
+			expectRedirect:   true,
+		},
+		{
+			name:           "path with query params and no trailing slash should pass through",
+			path:           "/v0/servers?limit=10",
+			expectedStatus: http.StatusOK,
+			expectRedirect: false,
+		},
+		{
+			name:             "path with query params and trailing slash should redirect preserving query params",
+			path:             "/v0/servers/?limit=10",
+			expectedStatus:   http.StatusPermanentRedirect,
+			expectedLocation: "/v0/servers?limit=10",
+			expectRedirect:   true,
 		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			req := httptest.NewRequest("GET", tt.path, nil)
+			req := httptest.NewRequest(http.MethodGet, tt.path, nil)
 			w := httptest.NewRecorder()
 
 			middleware.ServeHTTP(w, req)
@@ -77,4 +92,4 @@ func TestTrailingSlashMiddleware(t *testing.T) {
 			}
 		})
 	}
-}
+}