Fix lint

Author: domdomegg

internal/api/handlers/v0/publish_integration_test.go

@@ -98,15 +98,15 @@ func TestPublishIntegration(t *testing.T) {
 		require.NoError(t, err)
 
 		assert.NotEmpty(t, response.ID, "Server ID should be generated")
-		assert.Equal(t, publishReq.ServerDetail.Name, response.Name)
-		assert.Equal(t, publishReq.ServerDetail.Description, response.Description)
+		assert.Equal(t, publishReq.Name, response.Name)
+		assert.Equal(t, publishReq.Description, response.Description)
 
 		// Verify the server was actually published by retrieving it
 		publishedServer, err := registryService.GetByID(response.ID)
 		require.NoError(t, err)
-		assert.Equal(t, publishReq.ServerDetail.Name, publishedServer.Name)
-		assert.Equal(t, publishReq.ServerDetail.Description, publishedServer.Description)
-		assert.Equal(t, publishReq.ServerDetail.VersionDetail.Version, publishedServer.VersionDetail.Version)
+		assert.Equal(t, publishReq.Name, publishedServer.Name)
+		assert.Equal(t, publishReq.Description, publishedServer.Description)
+		assert.Equal(t, publishReq.VersionDetail.Version, publishedServer.VersionDetail.Version)
 		assert.Len(t, publishedServer.Packages, 1)
 		assert.Len(t, publishedServer.Remotes, 1)
 	})
@@ -326,8 +326,8 @@ func TestPublishIntegration(t *testing.T) {
 		// Verify that only the first server was actually stored
 		retrievedServer, err := registryService.GetByID(firstServerID)
 		require.NoError(t, err)
-		assert.Equal(t, firstServerDetail.ServerDetail.Name, retrievedServer.Name)
-		assert.Equal(t, firstServerDetail.ServerDetail.Description, retrievedServer.Description)
+		assert.Equal(t, firstServerDetail.Name, retrievedServer.Name)
+		assert.Equal(t, firstServerDetail.Description, retrievedServer.Description)
 	})
 
 	t.Run("publish succeeds with same name but different version", func(t *testing.T) {
@@ -551,15 +551,15 @@ func TestPublishIntegrationEndToEnd(t *testing.T) {
 		// Step 4: Verify the server can be retrieved by ID
 		retrievedServer, err := registryService.GetByID(serverID)
 		require.NoError(t, err)
-		assert.Equal(t, publishReq.ServerDetail.Name, retrievedServer.Name)
-		assert.Equal(t, publishReq.ServerDetail.Description, retrievedServer.Description)
+		assert.Equal(t, publishReq.Name, retrievedServer.Name)
+		assert.Equal(t, publishReq.Description, retrievedServer.Description)
 
 		// Step 5: Verify the server appears in the list
 		found := false
 		for _, server := range updatedServers {
 			if server.ID == serverID {
 				found = true
-				assert.Equal(t, publishReq.ServerDetail.Name, server.Name)
+				assert.Equal(t, publishReq.Name, server.Name)
 				break
 			}
 		}

internal/api/handlers/v0/publish_test.go

@@ -138,15 +138,15 @@ func TestPublishEndpoint(t *testing.T) {
 			name:           "missing authorization header",
 			requestBody:    model.PublishRequest{},
 			authHeader:     "",
-			setupMocks:     func(registry *MockRegistryService, authSvc *MockAuthService) {},
+			setupMocks:     func(_ *MockRegistryService, _ *MockAuthService) {},
 			expectedStatus: http.StatusUnprocessableEntity,
 			expectedError:  "required header parameter is missing",
 		},
 		{
 			name:           "invalid authorization header format",
 			requestBody:    model.PublishRequest{},
 			authHeader:     "InvalidFormat",
-			setupMocks:     func(registry *MockRegistryService, authSvc *MockAuthService) {},
+			setupMocks:     func(_ *MockRegistryService, _ *MockAuthService) {},
 			expectedStatus: http.StatusUnauthorized,
 			expectedError:  "Invalid Authorization header format",
 		},
@@ -167,7 +167,7 @@ func TestPublishEndpoint(t *testing.T) {
 				},
 			},
 			authHeader:     "Bearer token",
-			setupMocks:     func(registry *MockRegistryService, authSvc *MockAuthService) {},
+			setupMocks:     func(_ *MockRegistryService, _ *MockAuthService) {},
 			expectedStatus: http.StatusBadRequest,
 			expectedError:  "Name is required",
 		},
@@ -188,7 +188,7 @@ func TestPublishEndpoint(t *testing.T) {
 				},
 			},
 			authHeader:     "Bearer token",
-			setupMocks:     func(registry *MockRegistryService, authSvc *MockAuthService) {},
+			setupMocks:     func(_ *MockRegistryService, _ *MockAuthService) {},
 			expectedStatus: http.StatusBadRequest,
 			expectedError:  "Version is required",
 		},
@@ -209,7 +209,7 @@ func TestPublishEndpoint(t *testing.T) {
 				},
 			},
 			authHeader: "Bearer token",
-			setupMocks: func(registry *MockRegistryService, authSvc *MockAuthService) {
+			setupMocks: func(_ *MockRegistryService, authSvc *MockAuthService) {
 				authSvc.On("ValidateAuth", mock.Anything, mock.Anything).Return(false, auth.ErrAuthRequired)
 			},
 			expectedStatus: http.StatusUnauthorized,
@@ -232,7 +232,7 @@ func TestPublishEndpoint(t *testing.T) {
 				},
 			},
 			authHeader: "Bearer invalid_token",
-			setupMocks: func(registry *MockRegistryService, authSvc *MockAuthService) {
+			setupMocks: func(_ *MockRegistryService, authSvc *MockAuthService) {
 				authSvc.On("ValidateAuth", mock.Anything, mock.Anything).Return(false, nil)
 			},
 			expectedStatus: http.StatusUnauthorized,
@@ -266,7 +266,7 @@ func TestPublishEndpoint(t *testing.T) {
 			name: "method not allowed",
 			requestBody: nil,
 			authHeader: "",
-			setupMocks: func(registry *MockRegistryService, authSvc *MockAuthService) {},
+			setupMocks: func(_ *MockRegistryService, _ *MockAuthService) {},
 			expectedStatus: http.StatusMethodNotAllowed,
 			expectedError: "Method Not Allowed",
 		},
@@ -366,7 +366,7 @@ func TestPublishEndpoint(t *testing.T) {
 			if tc.name == "method not allowed" {
 				method = http.MethodGet
 			}
-			req, err := http.NewRequest(method, "/v0/publish", bytes.NewBuffer(requestBody))
+			req, err := http.NewRequestWithContext(context.Background(), method, "/v0/publish", bytes.NewBuffer(requestBody))
 			assert.NoError(t, err)
 			if method == http.MethodPost {
 				req.Header.Set("Content-Type", "application/json")
@@ -454,7 +454,7 @@ func TestPublishEndpointBearerTokenParsing(t *testing.T) {
 			requestBody, err := json.Marshal(serverDetail)
 			assert.NoError(t, err)
 
-			req, err := http.NewRequest(http.MethodPost, "/v0/publish", bytes.NewBuffer(requestBody))
+			req, err := http.NewRequestWithContext(context.Background(), http.MethodPost, "/v0/publish", bytes.NewBuffer(requestBody))
 			assert.NoError(t, err)
 			req.Header.Set("Authorization", tc.authHeader)
 			req.Header.Set("Content-Type", "application/json")
@@ -524,7 +524,7 @@ func TestPublishEndpointAuthMethodSelection(t *testing.T) {
 			requestBody, err := json.Marshal(serverDetail)
 			assert.NoError(t, err)
 
-			req, err := http.NewRequest(http.MethodPost, "/v0/publish", bytes.NewBuffer(requestBody))
+			req, err := http.NewRequestWithContext(context.Background(), http.MethodPost, "/v0/publish", bytes.NewBuffer(requestBody))
 			assert.NoError(t, err)
 			req.Header.Set("Authorization", "Bearer test_token")
 			req.Header.Set("Content-Type", "application/json")