Fix linting errors and unit tests

Signed-off-by: Radoslav Dimitrov <[email protected]>

Author: rdimitrov

CANONICAL_REFS_IMPLEMENTATION_SUMMARY.md

@@ -332,6 +332,9 @@ components:
             - identifier
             - version
           properties:
+            registryType:
+              type: string
+              enum: [npm]
             identifier:
               type: string
               description: "NPM package name (with or without @scope)"
@@ -360,6 +363,9 @@ components:
             - identifier
             - version
           properties:
+            registryType:
+              type: string
+              enum: [pypi]
             identifier:
               type: string
               description: "PyPI package name"
@@ -388,6 +394,9 @@ components:
             - identifier
             - version
           properties:
+            registryType:
+              type: string
+              enum: [nuget]
             identifier:
               type: string
               description: "NuGet package ID"
@@ -415,6 +424,9 @@ components:
           required:
             - identifier
           properties:
+            registryType:
+              type: string
+              enum: [oci]
             identifier:
               type: string
               description: "Full OCI image reference including registry, namespace, image, and tag/digest. Registry defaults to docker.io if not specified. Must include at least a tag or digest."
@@ -435,6 +447,9 @@ components:
             - identifier
             - fileSha256
           properties:
+            registryType:
+              type: string
+              enum: [mcpb]
             identifier:
               type: string
               format: uri

docs/reference/api/openapi.yaml

@@ -178,6 +178,12 @@
               "format": "uri",
               "minLength": 1,
               "type": "string"
+            },
+            "registryType": {
+              "enum": [
+                "mcpb"
+              ],
+              "type": "string"
             }
           },
           "required": [
@@ -209,6 +215,12 @@
               "format": "uri",
               "type": "string"
             },
+            "registryType": {
+              "enum": [
+                "npm"
+              ],
+              "type": "string"
+            },
             "version": {
               "description": "Package version. Must be a specific version. Version ranges are rejected (e.g., '^1.2.3', '~1.2.3', '\u003e=1.2.3', '1.x', '1.*').",
               "example": "1.0.2",
@@ -282,6 +294,12 @@
               "format": "uri",
               "type": "string"
             },
+            "registryType": {
+              "enum": [
+                "nuget"
+              ],
+              "type": "string"
+            },
             "version": {
               "description": "Package version. Must be a specific version. Version ranges are rejected.",
               "example": "1.0.2",
@@ -319,6 +337,12 @@
               ],
               "minLength": 1,
               "type": "string"
+            },
+            "registryType": {
+              "enum": [
+                "oci"
+              ],
+              "type": "string"
             }
           },
           "required": [
@@ -490,6 +514,12 @@
               "format": "uri",
               "type": "string"
             },
+            "registryType": {
+              "enum": [
+                "pypi"
+              ],
+              "type": "string"
+            },
             "version": {
               "description": "Package version. Must be a specific version. Version ranges are rejected.",
               "example": "1.0.2",

docs/reference/server-json/server.schema.json

@@ -95,7 +95,6 @@ func TestPublishRegistryValidation(t *testing.T) {
 				{
 					RegistryType: model.RegistryTypeMCPB,
 					Identifier:   "https://github.com/microsoft/playwright-mcp/releases/download/v0.0.36/playwright-mcp-extension-v0.0.36.zip",
-					Version:      "0.0.36",
 					FileSHA256:   "fe333e598595000ae021bd27117db32ec69af6987f507ba7a63c90638ff633ce",
 					Transport: model.Transport{
 						Type: model.TransportTypeStdio,
@@ -146,7 +145,6 @@ func TestPublishRegistryValidation(t *testing.T) {
 				{
 					RegistryType: model.RegistryTypeMCPB,
 					Identifier:   "https://github.com/microsoft/playwright-mcp/releases/download/v0.0.36/playwright-mcp-extension-v0.0.36.zip",
-					Version:      "1.0.0",
 					FileSHA256:   "fe333e598595000ae021bd27117db32ec69af6987f507ba7a63c90638ff633ce",
 					Transport: model.Transport{
 						Type: model.TransportTypeStdio,
@@ -206,7 +204,6 @@ func TestPublishRegistryValidation(t *testing.T) {
 				{
 					RegistryType: model.RegistryTypeMCPB,
 					Identifier:   "https://github.com/microsoft/playwright-mcp/releases/download/v0.0.36/playwright-mcp-extension-v0.0.36.zip",
-					Version:      "1.0.0",
 					FileSHA256:   "fe333e598595000ae021bd27117db32ec69af6987f507ba7a63c90638ff633ce",
 					Transport: model.Transport{
 						Type: model.TransportTypeStdio,

internal/api/handlers/v0/publish_registry_validation_test.go

@@ -158,21 +158,3 @@ func isValidGitLabReleaseURL(path string) bool {
 
 	return false
 }
-
-// inferMCPBRegistryBaseURL infers the registry base URL from an MCPB identifier
-func inferMCPBRegistryBaseURL(identifier string) (string, error) {
-	parsedURL, err := url.Parse(identifier)
-	if err != nil {
-		return "", err
-	}
-
-	host := strings.ToLower(parsedURL.Host)
-	switch host {
-	case "github.com", "www.github.com":
-		return model.RegistryURLGitHub, nil
-	case "gitlab.com", "www.gitlab.com":
-		return model.RegistryURLGitLab, nil
-	default:
-		return "", fmt.Errorf("invalid host for MCPB package: %s, expected github or gitlab", host)
-	}
-}