Skip to content

Commit cc1e665

Browse files
authored
Ensure no downtime during rollouts (#854)
<!-- Provide a brief summary of your changes --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> The following PR ensures we don't have downtime when we are doing rollouts during deployment/promotions. ## How Has This Been Tested? <!-- Have you tested this in a real application? Which scenarios were tested? --> ## Breaking Changes <!-- Will users need to update their code or configurations? --> ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ ] My code follows the repository's style guidelines - [ ] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed ## Additional context <!-- Add any other context, implementation notes, or design decisions --> Signed-off-by: Radoslav Dimitrov <[email protected]>
1 parent d71df40 commit cc1e665

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

deploy/pkg/k8s/registry.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,13 @@ func DeployMCPRegistry(ctx *pulumi.Context, cluster *providers.ProviderInfo, env
7272
},
7373
Spec: &v1.DeploymentSpecArgs{
7474
Replicas: pulumi.Int(2),
75+
Strategy: &v1.DeploymentStrategyArgs{
76+
Type: pulumi.String("RollingUpdate"),
77+
RollingUpdate: &v1.RollingUpdateDeploymentArgs{
78+
MaxUnavailable: pulumi.IntPtr(0), // Never reduce capacity during updates
79+
MaxSurge: pulumi.IntPtr(1), // Create new pods first, then terminate old
80+
},
81+
},
7582
Selector: &metav1.LabelSelectorArgs{
7683
MatchLabels: pulumi.StringMap{
7784
"app": pulumi.String("mcp-registry"),

0 commit comments

Comments
 (0)