Skip to content

Commit ddd694a

Browse files
authored
Fix the image reference for prod: from v1.3.0 to 1.3.0 (#669)
<!-- Provide a brief summary of your changes --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> The following PR fixes the docs and the image reference for prod since they don't expect to have the v prefix there. ## How Has This Been Tested? <!-- Have you tested this in a real application? Which scenarios were tested? --> ## Breaking Changes <!-- Will users need to update their code or configurations? --> ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ ] My code follows the repository's style guidelines - [ ] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed ## Additional context <!-- Add any other context, implementation notes, or design decisions --> --------- Signed-off-by: Radoslav Dimitrov <[email protected]>
1 parent ea01d06 commit ddd694a

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

deploy/Pulumi.gcpProd.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
config:
22
mcp-registry:environment: prod
33
mcp-registry:provider: gcp
4-
mcp-registry:imageTag: v1.3.0 # Set specific image tag for production (change this to deploy different versions)
4+
mcp-registry:imageTag: 1.3.0 # Set specific image tag for production (change this to deploy different versions)
55
gcp:project: mcp-registry-prod
66
mcp-registry:githubClientId: Iv23liUydBbI7Z2Q9bOZ
77
mcp-registry:githubClientSecret:

deploy/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,14 @@ PULUMI_CONFIG_PASSPHRASE="" pulumi config set mcp-registry:githubClientSecret --
4343
# Or via gh CLI:
4444
gh release create v1.2.3 --generate-notes
4545
```
46-
This builds Docker images tagged as `v1.2.3` and `latest`
46+
This builds Docker images tagged as `1.2.3` and `latest` (note: image tags do not include the 'v' prefix)
4747

4848
2. Update the production image tag in `Pulumi.gcpProd.yaml`:
4949
```bash
5050
# Edit deploy/Pulumi.gcpProd.yaml
51-
# Change line: mcp-registry:imageTag: v1.2.3
51+
# Change line: mcp-registry:imageTag: 1.2.3 (note: no 'v' prefix for Docker image tags)
5252
git add deploy/Pulumi.gcpProd.yaml
53-
git commit -m "Deploy v1.2.3 to production"
53+
git commit -m "Deploy version 1.2.3 to production"
5454
git push
5555
```
5656

docs/guides/contributing/releasing.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,20 @@
1010

1111
The release workflow will automatically:
1212
- Build binaries for 6 platforms (Linux, macOS, Windows × amd64, arm64)
13-
- Create and push Docker images with `:latest` and `:vX.Y.Z` tags
13+
- Create and push Docker images with `:latest` and `:X.Y.Z` tags (note: no 'v' prefix)
1414
- Attach all artifacts to the GitHub release
1515
- Generate checksums and signatures
1616

1717
## After Release
1818

1919
- Docker images will be available at:
2020
- `ghcr.io/modelcontextprotocol/registry:latest` - Latest stable release
21-
- `ghcr.io/modelcontextprotocol/registry:vX.Y.Z` - Specific release version
21+
- `ghcr.io/modelcontextprotocol/registry:X.Y.Z` - Specific release version (note: no 'v' prefix)
2222
- Binaries can be downloaded from the GitHub release page
2323

2424
**Note:** Releases do not automatically deploy to production. To deploy a release to production:
2525

26-
1. Update `mcp-registry:imageTag` in `deploy/Pulumi.gcpProd.yaml` to the desired version (e.g., `v1.2.3`)
26+
1. Update `mcp-registry:imageTag` in `deploy/Pulumi.gcpProd.yaml` to the desired version (e.g., `1.2.3` - note: no 'v' prefix)
2727
2. Commit and push the change to the `main` branch
2828
3. The [deploy-production.yml](../../../.github/workflows/deploy-production.yml) workflow will automatically trigger and deploy the specified version
2929

@@ -34,10 +34,12 @@ See the [deployment documentation](../../../deploy/README.md) for more details.
3434
The registry publishes different Docker image tags for different use cases:
3535

3636
- **`:latest`** - Latest stable release (updated only on releases)
37-
- **`:vX.Y.Z`** - Specific release versions (e.g., `:v1.0.0`)
37+
- **`:X.Y.Z`** - Specific release versions (e.g., `:1.0.0` - note: no 'v' prefix)
3838
- **`:main`** - Rolling tag updated on every push to main branch (continuous deployment)
3939
- **`:main-YYYYMMDD-sha`** - Specific development builds from main branch
4040

41+
**Note:** Git release tags include the 'v' prefix (e.g., `v1.0.0`), but Docker image tags follow the standard Docker convention and do not include the 'v' prefix (e.g., `1.0.0`).
42+
4143
## Versioning
4244

4345
We use semantic versioning (SemVer):

0 commit comments

Comments
 (0)