feat: namespace parsing validation by aphansal123 · Pull Request #218 · modelcontextprotocol/registry

aphansal123 · 2025-08-01T21:33:06Z

Namespace Parsing Validation and Server Status Management

This PR implements namespace parsing validation for domain-scoped server names and adds server status lifecycle management functionality to the MCP Metaregistry.

Motivation and Context

The MCP Metaregistry needs to support domain-scoped namespaces (e.g., com.github/my-server) to prevent namespace squatting and provide better organization. This change introduces:

Namespace Validation: Implements parsing and validation for domain-scoped namespaces using reverse domain notation
Server Status Management: Adds lifecycle status tracking (active/deprecated) to help users identify maintained vs. unmaintained servers
Reserved Namespace Protection: Prevents use of reserved domains like localhost, example, test, etc.
Domain Authentication Preparation: Lays groundwork for domain ownership verification system

How Has This Been Tested?

Added comprehensive unit tests for namespace parsing and validation (internal/namespace/namespace_test.go)
Added integration tests for publish handler namespace validation (internal/api/handlers/v0/publish_namespace_test.go)
Tested various namespace formats:
- Valid domain-scoped: com.github/my-server, org.apache.commons/utility
- Invalid formats: forward notation, missing components, reserved domains
- Legacy compatibility: existing io.github.* patterns still work
Updated JSON schema validation with status field
Updated publisher tool to support status parameter

Breaking Changes

Non-breaking changes:

Existing server names continue to work (backward compatibility maintained)
New status field is optional and defaults to "active"
Legacy namespace formats are still accepted during transition period

Future breaking change preparation:

Strict domain-scoped validation will be enforced in future versions
Domain verification system will be required for custom domains

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update

Checklist

I have read the MCP Documentation
My code follows the repository's style guidelines
New and existing tests pass locally
I have added appropriate error handling
I have added or updated documentation as needed

Additional context

Key Implementation Details

Namespace Package: New internal/namespace package handles all domain-scoped namespace parsing and validation
Status Field: Added ServerStatus enum with active and deprecated values across models, schemas, and examples
Authentication Logic: Updated publish handler to use domain-based authentication selection (currently defaults to GitHub auth for all custom domains pending domain verification implementation)
Reserved Domains: Comprehensive list of reserved namespaces prevents misuse of common test/example domains

Future Work

Domain ownership verification system (DNS TXT records and HTTP-01 challenges as documented in server-name-verification.md)
Stricter enforcement of domain-scoped format requirements
Integration with domain verification for authentication

Files Changed

New namespace parsing and validation system
Updated server models with status field
Enhanced publish handler with namespace validation
Updated JSON schemas and OpenAPI specs
Enhanced publisher CLI tool

… domain verification

…en_test.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…t package structure

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…rmance

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ure/dns-record-verification

Co-authored-by: Trent Jones <57182095+trent-j@users.noreply.github.com>

Config

…ure/dns-record-verification

…e/dns-record-verification

…lint issues

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…idation

Copilot

Pull Request Overview

This PR implements namespace parsing validation for domain-scoped server names (e.g., com.github/my-server) and adds server status lifecycle management (active/deprecated) to the MCP Metaregistry.

Introduces comprehensive namespace validation with support for reverse domain notation and reserved namespace protection
Adds server status field across all models, schemas, and examples to track lifecycle state
Updates tooling to support the new status parameter in publisher CLI and validation utilities

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
internal/namespace/namespace.go	New package implementing domain-scoped namespace parsing, validation, and reserved domain checking
internal/namespace/namespace_test.go	Comprehensive test suite for namespace parsing and validation functionality
internal/model/model.go	Adds ServerStatus enum and status field to Server model
internal/api/handlers/v0/publish.go	Updates publish handler with namespace validation and domain-based authentication logic
internal/api/handlers/v0/publish_namespace_test.go	Integration tests for namespace validation in publish handler
tools/publisher/main.go	Enhances publisher CLI tool with status parameter validation and support
tools/publisher/server.json	Updates template with new status field
tools/validate-examples/main.go	Updates expected example count and import alias
tools/validate-schemas/main.go	Updates import alias for consistency
docs/server-registry-api/openapi.yaml	Adds status field to OpenAPI schema definition
docs/server-registry-api/examples.md	Updates all examples with status field
docs/server-json/schema.json	Adds status field to JSON schema
docs/server-json/examples.md	Updates examples and adds deprecated server example

Copilot · 2025-08-05T17:18:46Z

tools/validate-examples/main.go

 	"strings"

-	"github.com/santhosh-tekuri/jsonschema/v5"
+	jsonschema "github.com/santhosh-tekuri/jsonschema/v5"


[nitpick] The import alias jsonschema is redundant since the package name is already jsonschema. Consider using a more specific alias like schema or remove the alias entirely to use the default package name.

Suggested change

jsonschema "github.com/santhosh-tekuri/jsonschema/v5"

"github.com/santhosh-tekuri/jsonschema/v5"

Copilot · 2025-08-05T17:18:47Z

tools/validate-schemas/main.go

 	"strings"

-	"github.com/santhosh-tekuri/jsonschema/v5"
+	jsonschema "github.com/santhosh-tekuri/jsonschema/v5"


[nitpick] The import alias jsonschema is redundant since the package name is already jsonschema. Consider using a more specific alias like schema or remove the alias entirely to use the default package name.

Suggested change

jsonschema "github.com/santhosh-tekuri/jsonschema/v5"

"github.com/santhosh-tekuri/jsonschema/v5"

Copilot · 2025-08-05T17:18:48Z

internal/namespace/namespace.go

+		// as the domain might be newly registered or not yet propagated
+		// This is just a basic sanity check for obvious invalid domains
+	}
+


DNS lookups can be slow and may block execution. Consider removing this network call during validation or making it optional/async, especially since the comment indicates it's a soft validation that doesn't affect the result.

Suggested change

…idation

domdomegg · 2025-08-08T14:32:44Z

internal/api/handlers/v0/publish.go

+				http.Error(w, "Invalid namespace: "+err.Error(), http.StatusBadRequest)
+				return
+			}
+			// For legacy formats, we'll allow them to pass through for now


I am a bit confused by the "legacy format" here - what is this for?

From a skim to me here, it seems like it's referring to "legacy" as Legacy io.github format, but I agree that's odd; it's not legacy, we intend to support it indefinitely (and in fact have a mechanism to potentially extend it to also support e.g. com.gitlab.{user} etc. So I'd call it something more like Psuedo-domain io.github format or Borrowed domain

Makes sense that this isn't a legacy format, @claude Please fix the comment here to reflect that this is a pseudo-domain io.github format/borrowed domain.

…idation

aphansal123 · 2025-08-08T15:41:06Z

@claude Can you please fix the comment on line 65 in publish.go to reflect that this is a pseudo-domain io.github format/borrowed domain?

claude · 2025-08-08T15:41:19Z

Claude finished @aphansal123's task —— View job

I'll help you fix the comment on line 65 in publish.go to properly reflect that this is a pseudo-domain io.github format rather than a legacy format.

Todo List

Read the current publish.go file to understand the context around line 65
Update the comment to reflect pseudo-domain/borrowed domain format
Commit and push the change

Progress Details

Completed! ✅

I've successfully updated the comment on lines 65-66 in internal/api/handlers/v0/publish.go:

Before:

// For legacy formats, we'll allow them to pass through for now
// This provides backward compatibility while encouraging new domain-scoped formats

After:

// For pseudo-domain io.github format/borrowed domain, we'll allow them to pass through
// This provides support for the borrowed io.github domain while encouraging new domain-scoped formats

The comment now accurately reflects that io.github is a pseudo-domain/borrowed domain format that's intended to be supported indefinitely, rather than a legacy format that might be deprecated in the future.

Changes committed and pushed to the feature/namespace-parsing-validation branch.

The comment on line 65-66 in publish.go has been updated to clarify that io.github is a pseudo-domain/borrowed domain format rather than a legacy format, as it's intended to be supported indefinitely. Co-authored-by: Ameya Phansalkar <aphansal123@users.noreply.github.com>

aphansal123 and others added 30 commits July 29, 2025 15:27

feat: implement 128-bit cryptographically secure token generation for…

72a1967

… domain verification

Merge branch 'main' into feature/domain-verification-token-generation

ffbed48

Fix package references and eliminate duplicate string literals in tok…

f375640

…en_test.go

Update internal/verification/README.md

f7a85fa

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update internal/verification/token_test.go

36579a1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Capitalize MaxDNSRecordLength variable name for consistency

382925e

Add comprehensive DNS TXT record RFC compliance validation tests

a9afe32

Fix gci linter error by removing trailing whitespace

bc4d621

Implement DNS TXT record verification for domain ownership validation

60ac929

Implement DNS record verification for domain ownership validation

1202ae0

Fix golangci-lint issues: improve error handling, formatting, and tes…

a19b6b5

…t package structure

Update server-name-verification.md

d8dba84

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: prevent timer leaks in DNS verification retry logic

2e4dc96

fix: correct spelling from 'cancelled' to 'canceled' in comment

2be9c9c

Update internal/verification/dns.go

bf1c847

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: correct retry attempt counter in DNS verification logging

b36f6af

fix: use mock DNS resolver in tests instead of real DNS queries

21ef581

fix: replace real DNS queries with mock resolver in timeout test

1d0316d

fix: convert DNS tests to mocks and optimize error handling for perfo…

f2e1fde

…rmance

User time.NewTimer and explicitly stop

80b36bf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Add maximum iteration limit to prevent infinite loops

147fc46

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: correct syntax error in DNS mock delay simulation

36262ff

test: improve DNS record format test and remove unused import

0ebca38

Remove ValidateTokenFormat and TokenInfo per PR feedback

efc077a

Merge branch 'feature/domain-verification-token-generation' into feat…

ea7857d

…ure/dns-record-verification

Update internal/verification/README.md

d378b27

Co-authored-by: Trent Jones <57182095+trent-j@users.noreply.github.com>

make DNS record prefix configurable in DNSVerification

adacb2c

Config

Merge branch 'feature/domain-verification-token-generation' into feat…

3322f15

…ure/dns-record-verification

Merge remote-tracking branch 'origin/remote-verification' into featur…

3b1c54a

…e/dns-record-verification

docs: fix README syntax errors and add RecordPrefix documentation

455ec12

aphansal123 added 2 commits August 1, 2025 17:56

Fix golangci-lint issues: improve error wrapping and code formatting

758f0f4

Add nolint comments for testpackage warnings to resolve all golangci-…

80b74a6

…lint issues

aphansal123 changed the base branch from main to feature/dns-record-verification August 1, 2025 22:09

aphansal123 requested a review from Copilot August 1, 2025 22:10

This comment was marked as resolved.

Sign in to view

Fix spelling issue in readme doc

dd203a1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

aphansal123 changed the title ~~Feature/namespace parsing validation~~ feat: namespace parsing validation Aug 3, 2025

Fix linter issues with jsonschema imports

c506ed0

aphansal123 changed the base branch from feature/dns-record-verification to main August 3, 2025 22:38

aphansal123 changed the base branch from main to feature/dns-record-verification August 3, 2025 22:38

Base automatically changed from feature/dns-record-verification to remote-verification August 3, 2025 22:40

Merge branch 'remote-verification' into feature/namespace-parsing-val…

d675d28

…idation

aphansal123 requested review from thomas-sickert and trent-j August 4, 2025 17:27

aphansal123 marked this pull request as ready for review August 4, 2025 21:28

Merge branch 'remote-verification' into feature/namespace-parsing-val…

3e7ae7e

…idation

aphansal123 requested a review from Copilot August 5, 2025 16:09

This comment was marked as outdated.

Sign in to view

aphansal123 requested a review from Copilot August 5, 2025 17:17

Copilot AI reviewed Aug 5, 2025

View reviewed changes

Merge branch 'remote-verification' into feature/namespace-parsing-val…

87978d6

…idation

domdomegg reviewed Aug 8, 2025

View reviewed changes

Merge branch 'remote-verification' into feature/namespace-parsing-val…

8502e4e

…idation

aphansal123 requested a review from tadasant August 8, 2025 15:43

Avish34 mentioned this pull request Aug 17, 2025

Sanitization, limits, enums on all free-form fields #97

Closed

domdomegg deleted the branch remote-verification September 9, 2025 15:27

domdomegg closed this Sep 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: namespace parsing validation#218

feat: namespace parsing validation#218
aphansal123 wants to merge 41 commits intoremote-verificationfrom
feature/namespace-parsing-validation

aphansal123 commented Aug 1, 2025 •

edited

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 5, 2025

Uh oh!

Copilot AI Aug 5, 2025

Uh oh!

Copilot AI Aug 5, 2025

Uh oh!

domdomegg Aug 8, 2025

Uh oh!

tadasant Aug 8, 2025

Uh oh!

aphansal123 Aug 8, 2025

Uh oh!

aphansal123 commented Aug 8, 2025

Uh oh!

claude bot commented Aug 8, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	jsonschema "github.com/santhosh-tekuri/jsonschema/v5"
	"github.com/santhosh-tekuri/jsonschema/v5"

Conversation

aphansal123 commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Namespace Parsing Validation and Server Status Management

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

Checklist

Additional context

Key Implementation Details

Future Work

Files Changed

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

domdomegg Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

tadasant Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

aphansal123 Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

aphansal123 commented Aug 8, 2025

Uh oh!

claude bot commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Todo List

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aphansal123 commented Aug 1, 2025 •

edited

Loading

claude bot commented Aug 8, 2025 •

edited

Loading