Skip to content

Tests failing in CI, CI shows as passing #834

@BobDickinson

Description

@BobDickinson

Describe the bug
When the CI job runs, the Tests target "Run all tests" has failing tests, but reports that it passes

To Reproduce
Review any recent CI run to see failing tests

Expected behavior
Tests should pass. If tests don't pass, CI shouldn't report Pass. These are two separate issues that both need to be fixed.

Logs

--- FAIL: TestValidateOCI_RegistryAllowlist (5.52s)
    --- FAIL: TestValidateOCI_RegistryAllowlist/Artifact_Registry_regional_should_be_allowed (1.43s)
        oci_test.go:118: 
            	Error Trace:	/home/runner/work/registry/registry/internal/validators/registries/oci_test.go:118
            	Error:      	"OCI image ownership validation failed. Expected annotation 'io.modelcontextprotocol.server.name' = 'com.example/test', got 'io.github.googleapis/genai-toolbox'" does not contain "missing required annotation"
            	Test:       	TestValidateOCI_RegistryAllowlist/Artifact_Registry_regional_should_be_allowed
    --- FAIL: TestValidateOCI_RegistryAllowlist/ACR_should_be_allowed (0.01s)
        oci_test.go:118: 
            	Error Trace:	/home/runner/work/registry/registry/internal/validators/registries/oci_test.go:118
            	Error:      	"failed to fetch OCI image: Get \"[https://azurearcjumpstart.azurecr.io/v2/\](https://azurearcjumpstart.azurecr.io/v2//)": dial tcp: lookup azurearcjumpstart.azurecr.io on 127.0.0.53:53: no such host" does not contain "missing required annotation"
            	Test:       	TestValidateOCI_RegistryAllowlist/ACR_should_be_allowed

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions