Skip to content

Commit db1ae35

Browse files
authored
Merge pull request #94 from andyw8/andyw8/use-valid-syntax-for-uri-examples
Use valid syntax for URIs in examples and tests
2 parents 52c92c7 + 8b92ce0 commit db1ae35

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

examples/http_server.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def template(args, server_context:)
6161
prompts: [ExamplePrompt],
6262
resources: [
6363
MCP::Resource.new(
64-
uri: "test_resource",
64+
uri: "https://test_resource.invalid",
6565
name: "Test resource",
6666
description: "Test resource that echoes back the uri as its content",
6767
mime_type: "text/plain",

examples/stdio_server.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def template(args, server_context:)
5858
prompts: [ExamplePrompt],
5959
resources: [
6060
MCP::Resource.new(
61-
uri: "test_resource",
61+
uri: "https://test_resource.invalid",
6262
name: "Test resource",
6363
description: "Test resource that echoes back the uri as its content",
6464
mime_type: "text/plain",

test/mcp/server/transports/stdio_notification_integration_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ def puts(message)
228228
# Add a resource and notify
229229
@server.resources = [
230230
MCP::Resource.new(
231-
uri: "test://resource",
231+
uri: "https://test_resource.invalid",
232232
name: "Test Resource",
233233
description: "A test resource",
234234
mime_type: "text/plain",

test/mcp/server_test.rb

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,14 @@ class ServerTest < ActiveSupport::TestCase
4444
end
4545

4646
@resource = Resource.new(
47-
uri: "test_resource",
47+
uri: "https://test_resource.invalid",
4848
name: "Test resource",
4949
description: "Test resource",
5050
mime_type: "text/plain",
5151
)
5252

5353
@resource_template = ResourceTemplate.new(
54-
uri_template: "test_resource/{id}",
54+
uri_template: "https://test_resource.invalid/{id}",
5555
name: "Test resource",
5656
description: "Test resource",
5757
mime_type: "text/plain",
@@ -532,7 +532,7 @@ def call(message:, server_context: nil)
532532

533533
test "#resources_list_handler sets the resources/list handler" do
534534
@server.resources_list_handler do
535-
[{ uri: "test_resource", name: "Test resource", description: "Test resource" }]
535+
[{ uri: "https://test_resource.invalid", name: "Test resource", description: "Test resource" }]
536536
end
537537

538538
request = {
@@ -543,7 +543,7 @@ def call(message:, server_context: nil)
543543

544544
response = @server.handle(request)
545545
assert_equal(
546-
{ resources: [{ uri: "test_resource", name: "Test resource", description: "Test resource" }] },
546+
{ resources: [{ uri: "https://test_resource.invalid", name: "Test resource", description: "Test resource" }] },
547547
response[:result],
548548
)
549549
assert_instrumentation_data({ method: "resources/list" })
@@ -555,13 +555,13 @@ def call(message:, server_context: nil)
555555
method: "resources/read",
556556
id: 1,
557557
params: {
558-
uri: "example.com",
558+
uri: "https://test_resource.invalid",
559559
},
560560
}
561561

562562
response = @server.handle(request)
563563
assert_equal({ contents: [] }, response[:result])
564-
assert_instrumentation_data({ method: "resources/read", resource_uri: "example.com" })
564+
assert_instrumentation_data({ method: "resources/read", resource_uri: "https://test_resource.invalid" })
565565
end
566566

567567
test "#resources_read_handler sets the resources/read handler" do
@@ -578,13 +578,13 @@ def call(message:, server_context: nil)
578578
method: "resources/read",
579579
id: 1,
580580
params: {
581-
uri: "example.com/my_resource",
581+
uri: "https://test_resource.invalid/my_resource",
582582
},
583583
}
584584

585585
response = @server.handle(request)
586586
assert_equal(
587-
{ contents: { uri: "example.com/my_resource", mimeType: "text/plain", text: "Lorem ipsum dolor sit amet" } },
587+
{ contents: { uri: "https://test_resource.invalid/my_resource", mimeType: "text/plain", text: "Lorem ipsum dolor sit amet" } },
588588
response[:result],
589589
)
590590
end

0 commit comments

Comments
 (0)