Tidy up CORS error catching

jerome3o-anthropic · jerome3o-anthropic · commit 26b47438c60a · 2025-02-24T10:39:38.000Z
diff --git a/src/client/auth.ts b/src/client/auth.ts
@@ -170,11 +170,12 @@ export async function discoverOAuthMetadata(
         "MCP-Protocol-Version": opts?.protocolVersion ?? LATEST_PROTOCOL_VERSION
       }
     });
-  } catch {
-    try {
+  } catch (error) {
+    // CORS errors come back as TypeError
+    if (error instanceof TypeError) {
       response = await fetch(url);
-    } catch {
-      return undefined;
+    } else {
+      throw error;
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -170,11 +170,12 @@ export async function discoverOAuthMetadata(`
`170`	`170`	`"MCP-Protocol-Version": opts?.protocolVersion ?? LATEST_PROTOCOL_VERSION`
`171`	`171`	`}`
`172`	`172`	`});`
`173`		`- } catch {`
`174`		`- try {`
	`173`	`+ } catch (error) {`
	`174`	`+ // CORS errors come back as TypeError`
	`175`	`+ if (error instanceof TypeError) {`
`175`	`176`	`response = await fetch(url);`
`176`		`- } catch {`
`177`		`- return undefined;`
	`177`	`+ } else {`
	`178`	`+ throw error;`
`178`	`179`	`}`
`179`	`180`	`}`
`180`	`181`