Gearing up to "make amp do it"

Author: geelen

examples/inspector/vite.config.ts

@@ -6,7 +6,7 @@ import tailwindcss from '@tailwindcss/vite'
 export default defineConfig({
   plugins: [react(), tailwindcss()],
   build: {
-    // @ts-ignore
-    minify: !process.env.NO_MINIFY,
+    // @ts-expect-error I don't want to install @types/node for this one line
+    minify: process.env.NO_MINIFY !== "true",
   },
 })

test/integration/mcp-connection.test.ts

@@ -217,23 +217,23 @@ describe('MCP Connection Integration Tests', () => {
 
   const testScenarios = [
     // Working examples with auto transport (should pass)
-    { serverName: 'hono-mcp', transportType: 'auto' as const, shouldPass: true },
-    { serverName: 'cf-agents', transportType: 'auto' as const, shouldPass: true },
+    { serverName: 'hono-mcp', transportType: 'auto' as const },
+    { serverName: 'cf-agents', transportType: 'auto' as const },
 
     // SSE endpoint with SSE transport (should pass)
-    { serverName: 'cf-agents-sse', transportType: 'sse' as const, shouldPass: true },
+    { serverName: 'cf-agents-sse', transportType: 'sse' as const },
 
     // Additional test cases for HTTP transport
-    { serverName: 'hono-mcp', transportType: 'http' as const, shouldPass: true },
-    { serverName: 'cf-agents', transportType: 'http' as const, shouldPass: true },
+    { serverName: 'hono-mcp', transportType: 'http' as const },
+    { serverName: 'cf-agents', transportType: 'http' as const },
 
     // Failing case: SSE endpoint with auto transport (should fail)
-    { serverName: 'cf-agents-sse', transportType: 'auto' as const, shouldPass: false },
+    { serverName: 'cf-agents-sse', transportType: 'auto' as const },
   ]
 
   test.each(testScenarios)(
     'should connect to $serverName with $transportType transport (expect: $shouldPass)',
-    async ({ serverName, transportType, shouldPass }) => {
+    async ({ serverName, transportType }) => {
       const servers = getMCPServers()
       const server = servers.find((s) => s.name === serverName)
 
@@ -245,38 +245,25 @@ describe('MCP Connection Integration Tests', () => {
 
       const result = await connectToMCPServer(page, server.url, transportType)
 
-      if (shouldPass) {
-        if (result.success) {
-          console.log(`✅ Successfully connected to ${server.name}`)
-          console.log(`📋 Available tools (${result.tools.length}):`)
-          result.tools.forEach((tool, index) => {
-            console.log(`   ${index + 1}. ${tool}`)
-          })
-
-          // Verify connection success
-          expect(result.success).toBe(true)
-          expect(result.tools.length).toBeGreaterThanOrEqual(server.expectedTools)
-        } else {
-          console.log(`❌ Failed to connect to ${server.name}`)
-          if (result.debugLog) {
-            console.log(`🐛 Debug log:`)
-            console.log(result.debugLog)
-          }
+      if (result.success) {
+        console.log(`✅ Successfully connected to ${server.name}`)
+        console.log(`📋 Available tools (${result.tools.length}):`)
+        result.tools.forEach((tool, index) => {
+          console.log(`   ${index + 1}. ${tool}`)
+        })
 
-          // Fail the test with detailed information
-          throw new Error(`Expected to connect to ${server.name} with ${transportType} transport but failed. Debug log: ${result.debugLog}`)
-        }
+        // Verify connection success
+        expect(result.success).toBe(true)
+        expect(result.tools.length).toBeGreaterThanOrEqual(server.expectedTools)
       } else {
-        // Expect failure
-        if (result.success) {
-          console.log(`❌ Unexpectedly connected to ${server.name}`)
-          throw new Error(`Expected connection to ${server.name} with ${transportType} transport to fail, but it succeeded`)
-        } else {
-          console.log(`✅ Connection to ${server.name} failed as expected`)
-          console.log(`🐛 Debug log: ${result.debugLog}`)
-          // Verify it's actually a failure
-          expect(result.success).toBe(false)
+        console.log(`❌ Failed to connect to ${server.name}`)
+        if (result.debugLog) {
+          console.log(`🐛 Debug log:`)
+          console.log(result.debugLog)
         }
+
+        // Fail the test with detailed information
+        throw new Error(`Expected to connect to ${server.name} with ${transportType} transport but failed. Debug log: ${result.debugLog}`)
       }
     },
     45000,

test/setup/global-setup.ts

@@ -113,12 +113,13 @@ function findAvailablePortFromBase(basePort: number): Promise<number> {
   })
 }
 
-function runCommand(command: string, args: string[], cwd: string): Promise<void> {
+function runCommand(command: string, args: string[], cwd: string, env?: Record<string, string>): Promise<void> {
   return new Promise((resolve, reject) => {
     const child = spawn(command, args, {
       cwd,
       stdio: 'inherit',
       shell: true,
+      env: env ? { ...process.env, ...env } : process.env,
     })
 
     child.on('close', (code) => {
@@ -209,7 +210,7 @@ export default async function globalSetup() {
     // Step 2: Build inspector example
     console.log('📦 Building inspector example...')
     const inspectorDir = join(rootDir, 'examples/inspector')
-    await runCommand('pnpm', ['build'], inspectorDir)
+    await runCommand('pnpm', ['build'], inspectorDir, {NO_MINIFY: "true"})
 
     // Step 3: Find available port and start hono-mcp server
     console.log('🔍 Finding available port starting from 9901...')