Skip to content

Commit f069c29

Browse files
committed
Remove console logging for parsing errors (parsing errors are expected when autocompleting)
1 parent f37ca14 commit f069c29

File tree

3 files changed

+14
-11
lines changed

3 files changed

+14
-11
lines changed

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "sql-autocomplete",
3-
"version": "1.0.1",
3+
"version": "1.0.2",
44
"description": "Autocomplete recommendations for SQL statements. Supports PostgreSQL, MySQL, SQL Server and Oracle (PL/SQL) dialects.",
55
"main": "dist/index.js",
66
"types": "dist/index.d.ts",
@@ -29,10 +29,10 @@
2929
"bugs": {
3030
"url": "https://github.com/modeldba/sql-autocomplete/issues"
3131
},
32-
"homepage": "https://github.com/modeldba/sql-autocomplete#readme",
32+
"homepage": "https://modeldba.com/sql-autocomplete",
3333
"dependencies": {
3434
"antlr4-c3": "^1.1.12",
35-
"antlr4ts-sql": "^1.0.2"
35+
"antlr4ts-sql": "^1.0.3"
3636
},
3737
"devDependencies": {
3838
"jest": "^26.5.2",

src/SQLAutocomplete.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export class SQLAutocomplete {
2121
// it's not needed and keeping it in may impact which token gets selected for prediction
2222
sqlScript = sqlScript.substring(0, atIndex);
2323
}
24-
const tokens = this.antlr4tssql.getTokens(sqlScript);
24+
const tokens = this._getTokens(sqlScript);
2525
const parser = this._getParser(tokens);
2626
const core = new CodeCompletionCore(parser);
2727
const preferredRulesTable = this._getPreferredRulesForTable();
@@ -92,14 +92,17 @@ export class SQLAutocomplete {
9292
return autocompleteOptions;
9393
}
9494

95+
_getTokens(sqlScript: string): CommonTokenStream {
96+
const tokens = this.antlr4tssql.getTokens(sqlScript, []);
97+
return tokens;
98+
}
99+
95100
_getParser(tokens: CommonTokenStream): Parser {
96-
let parser = this.antlr4tssql.getParser(tokens);
97-
parser.removeErrorListener(ConsoleErrorListener.INSTANCE);
101+
let parser = this.antlr4tssql.getParser(tokens, []);
98102
parser.interpreter.setPredictionMode(PredictionMode.LL);
99103
return parser;
100104
}
101105

102-
103106
_tokenizeWhitespace() {
104107
if (this.dialect === SQLDialect.TSQL) {
105108
return false; // TSQL grammar SKIPs whitespace

0 commit comments

Comments
 (0)