Skip to content

Commit 1013fa1

Browse files
committed
chore: removed commented out code
1 parent bdde9be commit 1013fa1

File tree

2 files changed

+0
-53
lines changed

2 files changed

+0
-53
lines changed

model-client/src/commonMain/kotlin/org/modelix/model/client2/ReplicatedModel.kt

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -63,37 +63,11 @@ class ReplicatedModel(
6363
}
6464
}
6565

66-
// convergence watchdog
67-
// scope.launch {
68-
// var nextDelayMs: Long = 1000
69-
// while (state != State.Disposed) {
70-
// if (nextDelayMs > 0) delay(nextDelayMs)
71-
// try {
72-
// val newRemoteVersion = remoteVersion.pull()
73-
// remoteVersionReceived(newRemoteVersion)
74-
// nextDelayMs = 1000
75-
// } catch (ex: CancellationException) {
76-
// break
77-
// } catch (ex: Throwable) {
78-
// LOG.error(ex) { "Failed to pull branch $branchRef" }
79-
// nextDelayMs = (nextDelayMs * 3 / 2).coerceIn(1000, 30000)
80-
// }
81-
// }
82-
// }
83-
8466
localModel.rawBranch.addListener(object : IBranchListener {
8567
override fun treeChanged(oldTree: ITree?, newTree: ITree) {
8668
if (isDisposed()) return
8769
scope.launch {
8870
pushLocalChanges()
89-
// while (state != State.Disposed) {
90-
// if (remoteVersion.getNumberOfUnconfirmed() == 0) {
91-
// pushLocalChanges()
92-
// break
93-
// } else {
94-
// delay(100.milliseconds)
95-
// }
96-
// }
9771
}
9872
}
9973
})

model-datastructure/src/commonMain/kotlin/org/modelix/model/VersionMerger.kt

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -63,21 +63,6 @@ class VersionMerger(private val storeCache: IDeserializingKeyValueStore, private
6363
if (commonBase?.hash == leftVersion.hash) return rightVersion
6464
if (commonBase?.hash == rightVersion.hash) return leftVersion
6565

66-
// val leftHistory = HashMap<Long, CLVersion>().also { collectVersions(leftVersion, commonBase, it) }
67-
// val rightHistory = HashMap<Long, CLVersion>().also { collectVersions(leftVersion, commonBase, it) }
68-
// val leftNonMerges = leftHistory.values.asSequence().filter { !it.isMerge() }.map { it.id }.toSet()
69-
// val rightNonMerges = rightHistory.values.asSequence().filter { !it.isMerge() }.map { it.id }.toSet()
70-
//
71-
// if (leftNonMerges == rightNonMerges) {
72-
// // If there is no actual change on both sides, but they just did the same merge, we have to pick one
73-
// // of them, otherwise both sides will continue creating merges forever.
74-
// return if (leftVersion.id < rightVersion.id) leftVersion else rightVersion
75-
// } else if ((leftNonMerges - rightNonMerges).isEmpty()) {
76-
// return rightVersion // the right history already contains all the left history
77-
// } else if ((rightNonMerges - leftNonMerges).isEmpty()) {
78-
// return leftVersion // the left history already contains all the right history
79-
// }
80-
8166
val leftNonMerges = HashSet<Long>().also { collectLatestNonMerges(leftVersion, HashSet(), it) }
8267
val rightNonMerges = HashSet<Long>().also { collectLatestNonMerges(rightVersion, HashSet(), it) }
8368
if (leftNonMerges == rightNonMerges) {
@@ -88,7 +73,6 @@ class VersionMerger(private val storeCache: IDeserializingKeyValueStore, private
8873

8974
val versionsToApply = LinearHistory(commonBase?.hash).load(leftVersion, rightVersion)
9075

91-
// println("merge ${getVersion(leftVersionHash).id.toString(16)} ${LinearHistory(storeCache, commonBase).load(leftVersion).map { it.id.toString(16) }} and ${getVersion(rightVersionHash).id.toString(16)} ${LinearHistory(storeCache, commonBase).load(rightVersion).map { it.id.toString(16) }}: ${commonBase?.let{getVersion(it)}?.id?.toString(16)} + ${versionsToApply.map { it.id.toString(16) }}")
9276
val operationsToApply = versionsToApply.flatMap { captureIntend(it) }
9377
var mergedVersion: CLVersion? = null
9478
var baseTree = commonBase?.tree ?: CLTree(storeCache)
@@ -126,7 +110,6 @@ class VersionMerger(private val storeCache: IDeserializingKeyValueStore, private
126110
appliedOps.map { it.getOriginalOp() }.toTypedArray(),
127111
storeCache,
128112
)
129-
// println("result ${mergedVersion?.id?.toString(16)}")
130113
}
131114
if (mergedVersion == null) {
132115
throw RuntimeException("Failed to merge ${leftVersion.hash} and ${rightVersion.hash}")
@@ -190,15 +173,5 @@ class VersionMerger(private val storeCache: IDeserializingKeyValueStore, private
190173
}
191174
return null
192175
}
193-
194-
fun collectVersions(version: CLVersion?, commonBase: CLVersion?, result: MutableMap<Long, CLVersion>) {
195-
if (version == null) return
196-
if (result.containsKey(version.id)) return
197-
if (version.id == commonBase?.id) return
198-
result.put(version.id, version)
199-
collectVersions(version.baseVersion, commonBase, result)
200-
collectVersions(version.getMergedVersion1(), commonBase, result)
201-
collectVersions(version.getMergedVersion2(), commonBase, result)
202-
}
203176
}
204177
}

0 commit comments

Comments
 (0)