fix(model-datastructure): repeated wrapping with AsyncStoreAsLegacyDeserializingStore

`AsyncStoreAsLegacyDeserializingStore` and are adapters `LegacyDeserializingStoreAsAsyncStore` that
convert between `IDeserializingKeyValueStore` and `IAsyncObjectStore`.
While converting between these two interfaces, another adapter was added instead of unwrapping an
existing one, causing the call stack to keep growing util it was to large (StackOverflowError).

Author: slisson

model-datastructure/src/commonMain/kotlin/org/modelix/model/lazy/CLTree.kt

@@ -12,7 +12,6 @@ import org.modelix.model.api.ITree
 import org.modelix.model.api.async.getAncestors
 import org.modelix.model.api.async.getDescendants
 import org.modelix.model.async.AsyncAsSynchronousTree
-import org.modelix.model.async.AsyncStoreAsLegacyDeserializingStore
 import org.modelix.model.async.AsyncTree
 import org.modelix.model.async.IAsyncObjectStore
 import org.modelix.model.persistent.CPHamtInternal
@@ -58,7 +57,7 @@ class CLTree(val data: CPTree, val asyncStore: IAsyncObjectStore) : ITree by Asy
         store,
     )
 
-    val store: IDeserializingKeyValueStore = AsyncStoreAsLegacyDeserializingStore(asyncStore)
+    val store: IDeserializingKeyValueStore = asyncStore.getLegacyObjectStore()
 
     override fun getId(): String = data.id
 

model-datastructure/src/commonMain/kotlin/org/modelix/model/lazy/CLVersion.kt

@@ -22,7 +22,6 @@ import org.modelix.model.api.PNodeReference
 import org.modelix.model.api.TreePointer
 import org.modelix.model.api.async.getDescendants
 import org.modelix.model.async.AsyncAsSynchronousTree
-import org.modelix.model.async.AsyncStoreAsLegacyDeserializingStore
 import org.modelix.model.async.AsyncTree
 import org.modelix.model.async.BulkQueryAsAsyncStore
 import org.modelix.model.async.IAsyncObjectStore
@@ -277,7 +276,7 @@ class CLVersion : IVersion {
         }
 
         fun tryLoadFromHash(hash: String, store: IAsyncObjectStore): Maybe<CLVersion> {
-            return KVEntryReference(hash, CPVersion.DESERIALIZER).getValue(store).notNull().map { CLVersion(it, AsyncStoreAsLegacyDeserializingStore(store)) }
+            return KVEntryReference(hash, CPVersion.DESERIALIZER).getValue(store).notNull().map { CLVersion(it, store) }
         }
     }
 

model-datastructure/src/commonMain/kotlin/org/modelix/model/lazy/IKVEntryReference.kt

@@ -1,7 +1,6 @@
 package org.modelix.model.lazy
 
 import com.badoo.reaktive.single.Single
-import org.modelix.model.async.AsyncStoreAsLegacyDeserializingStore
 import org.modelix.model.async.IAsyncObjectStore
 import org.modelix.model.persistent.IKVValue
 
@@ -13,5 +12,5 @@ interface IKVEntryReference<out E : IKVValue> {
     fun getUnwrittenValue(): E
     fun getDeserializer(): (String) -> E
     fun write(store: IDeserializingKeyValueStore)
-    fun write(store: IAsyncObjectStore) = write(AsyncStoreAsLegacyDeserializingStore(store))
+    fun write(store: IAsyncObjectStore) = write(store.getLegacyObjectStore())
 }