build(ts-model-api): move from TSLint to ESLint

TSLint is deprecated and ESLint is the recommended successor.
Do not preserve the old TSLint configuration.
Start with the recommended ESLint configuration.

Author: Oleksandr Dzhychko

ts-model-api/.eslintrc.json

@@ -0,0 +1,21 @@
+{
+    "env": {
+        "browser": true,
+        "es2021": true,
+        "node": true
+    },
+    "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/recommended"
+    ],
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "ecmaVersion": "latest",
+        "sourceType": "module"
+    },
+    "plugins": [
+        "@typescript-eslint"
+    ],
+    "rules": {
+    }
+}

ts-model-api/package-lock.json

@@ -26,21 +26,22 @@
   "scripts": {
     "build": "tsc -p tsconfig.prod.json",
     "clean": "shx rm -rf dist/ .*cache *.log",
-    "lint": "npm run lint:debug -- --config tslint.prod.json",
-    "lint:debug": "tslint --project tsconfig.json --format stylish",
+    "lint": "eslint src",
+    "lint:fix": "npm run lint -- --fix",
     "test": "shx echo 'Write your own tests'",
     "ts": "tsc",
     "watch": "tsc --watch",
     "generateKotlin": "dukat -m \"@modelix/ts-model-api\" -d build/dukat dist/*.d.ts"
   },
   "devDependencies": {
     "@reallyland/tsconfig": "^2.0.0",
-    "@reallyland/tslint-config": "^1.1.1",
     "@types/node": "^20.11.28",
+    "@typescript-eslint/eslint-plugin": "^6.20.0",
+    "@typescript-eslint/parser": "^6.20.0",
     "dukat": "^0.5.8-rc.4",
+    "eslint": "^8.56.0",
     "husky": "^9.0.11",
     "shx": "^0.3.2",
-    "tslint": "^6.1.0",
     "typescript": "^4.7.4"
   },
   "engines": {

ts-model-api/package.json

@@ -1,4 +1,4 @@
-import type {ITypedNode, TypedNode} from "./TypedNode.js";
+import type {ITypedNode} from "./TypedNode.js";
 import type {INodeJS} from "./INodeJS.js";
 import {LanguageRegistry} from "./LanguageRegistry.js";
 import type {IConceptJS} from "./IConceptJS.js";
@@ -40,12 +40,12 @@ export class SingleChildAccessor<ChildT extends ITypedNode> extends ChildrenAcce
   }
 
   public get(): ChildT | undefined {
-    let children = this.asArray()
+    const children = this.asArray()
     return children.length === 0 ? undefined : children[0]
   }
 
   public setNew(): ChildT {
-    let existing = this.get();
+    const existing = this.get();
     if (existing !== undefined) {
       this.parentNode.removeChild(existing.unwrap())
     }

ts-model-api/src/ChildrenAccessor.ts

@@ -25,4 +25,5 @@ export interface INodeJS {
   setPropertyValue(role: string, value: string | undefined): void
 }
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unused-vars -- Keep for backward compatibility
 type INodeReferenceJS = any

ts-model-api/src/INodeJS.ts

@@ -33,24 +33,24 @@ export class LanguageRegistry {
   public wrapNode(node: INodeJS): ITypedNode {
     if (this.nodeWrappers === undefined) {
       this.nodeWrappers = new Map()
-      for (let lang of this.languages.values()) {
-        for (let entry of lang.nodeWrappers.entries()) {
+      for (const lang of this.languages.values()) {
+        for (const entry of lang.nodeWrappers.entries()) {
           this.nodeWrappers.set(entry[0], entry[1])
         }
       }
     }
-    let conceptUID = node.getConceptUID();
+    const conceptUID = node.getConceptUID();
     if (conceptUID === undefined) return new TypedNode(node)
-    let wrapper = this.nodeWrappers.get(conceptUID)
-    let wrapped = wrapper === undefined ? new UnknownTypedNode(node) : wrapper(node);
+    const wrapper = this.nodeWrappers.get(conceptUID)
+    const wrapped = wrapper === undefined ? new UnknownTypedNode(node) : wrapper(node);
     return this.wrapperCache ? this.wrapperCache(wrapped) : wrapped
   }
 
   public resolveConcept(uid: string): IConceptJS | undefined {
     if (this.concepts === undefined) {
       this.concepts = new Map()
-      for (let language of this.getAll()) {
-        for (let concept of language.getConcepts()) {
+      for (const language of this.getAll()) {
+        for (const concept of language.getConcepts()) {
           this.concepts.set(concept.getUID(), concept)
         }
       }

ts-model-api/src/LanguageRegistry.ts

@@ -1,5 +1,3 @@
-import type {INodeJS} from "./INodeJS.js";
-
 export type NodeId = string
 
 export interface IModelServerConnection {
@@ -32,18 +30,18 @@ export class ModelService {
     this.versionHash = data.versionHash
     if (data.root !== undefined) this.loadNode(data.root)
     if (data.nodes !== undefined) {
-      for (let node of data.nodes) {
+      for (const node of data.nodes) {
         this.loadNode(node)
       }
     }
   }
 
   private loadNode(nodeData: NodeData): NodeId {
     this.nodes.set(nodeData.nodeId, nodeData)
-    for (let childRole of Object.entries(nodeData.children)) {
-      let children: Array<NodeId | NodeData> = childRole[1] as any
+    for (const childRole of Object.entries(nodeData.children)) {
+      const children: Array<NodeId | NodeData> = childRole[1] as Array<NodeId | NodeData>
       for (let i = 0; i < children.length; i++) {
-        let child = children[i];
+        const child = children[i];
         if (typeof child === "object") {
           children[i] = this.loadNode(child)
         }
@@ -53,7 +51,7 @@ export class ModelService {
   }
 
   public addNewNode(parent: NodeId, role: string, index: number, concept: string) {
-    let body = [<NodeUpdateData>{
+    const body = [<NodeUpdateData>{
       nodeId: this.idGenerator.generate(),
       parent: parent,
       role: role,
@@ -64,7 +62,7 @@ export class ModelService {
   }
 
   public getChildren(parentId: NodeId, role: string): NodeId[] {
-    let parentData = this.nodes.get(parentId)
+    const parentData = this.nodes.get(parentId)
     if (parentData === undefined) return []
     return parentData.children[role]
   }
@@ -75,18 +73,18 @@ export class ModelService {
 
   public getProperty(nodeId: NodeId, role: string): string | undefined {
     console.log("getProperty(" + nodeId + ", " + role + ")")
-    let node = this.nodes.get(nodeId);
+    const node = this.nodes.get(nodeId);
     if (node === undefined) return undefined;
     return node.properties[role];
   }
 
   public setProperty(nodeId: NodeId, role: string, value: string | null | undefined) {
     console.log(`setProperty(${nodeId}, ${role}, ${value})`)
-    let node = this.nodes.get(nodeId);
+    const node = this.nodes.get(nodeId);
     if (node === undefined) return
     if (node.properties[role] === value) return
 
-    let body = [<NodeUpdateData>{
+    const body = [<NodeUpdateData>{
       nodeId: nodeId,
       properties: {
         [role]: value === undefined ? null : value
@@ -181,8 +179,11 @@ interface VersionData {
 
 interface NodeData {
   nodeId: NodeId,
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unused-vars -- Keep for backward compatibility
   references: any,
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unused-vars -- Keep for backward compatibility
   properties: any,
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unused-vars -- Keep for backward compatibility
   children: any
 }
 
@@ -192,8 +193,11 @@ interface NodeUpdateData {
   role: string | undefined,
   index: number | undefined,
   concept: string | undefined,
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unused-vars -- Keep for backward compatibility
   references: any,
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unused-vars -- Keep for backward compatibility
   properties: any,
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unused-vars -- Keep for backward compatibility
   children: any
 }
 
@@ -208,7 +212,7 @@ class IdGenerator {
   }
 
   public generate(): NodeId {
-    let id = this.next++;
+    const id = this.next++;
     if (id > this.last) throw Error("Out of IDs")
     // TODO get new IDs from the server
     return id.toString()