fix(mps-model-adapters): some write access implementations ignored incorrect usage

Author: slisson

mps-model-adapters/src/main/kotlin/org/modelix/model/mpsadapters/MPSModelAsNode.kt

@@ -111,7 +111,9 @@ data class MPSModelAsNode(val model: SModel) : IDeprecatedNodeDefaults {
     }
 
     override fun setPropertyValue(property: IProperty, value: String?) {
-        // TODO("Not yet implemented")
+        if (getPropertyValue(property) != value) {
+            throw UnsupportedOperationException("Property $property of $concept is read-only")
+        }
     }
 
     override fun getPropertyLinks(): List<IProperty> {

mps-model-adapters/src/main/kotlin/org/modelix/model/mpsadapters/MPSNodeReference.kt

@@ -55,6 +55,6 @@ object MPSNodeReferenceSerializer : INodeReferenceSerializerEx {
     }
 
     override fun deserialize(serialized: String): INodeReference {
-        TODO("Not yet implemented")
+        return MPSNodeReference(SNodePointer.deserialize(serialized))
     }
 }

mps-model-adapters/src/main/kotlin/org/modelix/model/mpsadapters/MPSRepositoryAsNode.kt

@@ -85,11 +85,15 @@ data class MPSRepositoryAsNode(val repository: SRepository) : IDeprecatedNodeDef
     }
 
     override fun setReferenceTarget(link: IReferenceLink, target: INode?) {
-        return
+        if (target != null) {
+            throw IllegalArgumentException("$concept doesn't contain a reference link $link")
+        }
     }
 
     override fun setReferenceTarget(role: IReferenceLink, target: INodeReference?) {
-        return
+        if (target != null) {
+            throw IllegalArgumentException("$concept doesn't contain a reference link $role")
+        }
     }
 
     override fun getReferenceTargetRef(role: IReferenceLink): INodeReference? {
@@ -101,7 +105,9 @@ data class MPSRepositoryAsNode(val repository: SRepository) : IDeprecatedNodeDef
     }
 
     override fun setPropertyValue(property: IProperty, value: String?) {
-        TODO("Not yet implemented")
+        if (value != null) {
+            throw IllegalArgumentException("$concept doesn't contain a property $property")
+        }
     }
 
     override fun getPropertyLinks(): List<IProperty> {