Skip to content

Commit 60e7dd4

Browse files
authored
Merge pull request #1451 from modelix/hmac-key-length
fix(authorization): HMAC512 key length requirement was 512 bytes instead of bits
2 parents cc45948 + 31db227 commit 60e7dd4

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

authorization/src/main/kotlin/org/modelix/authorization/AuthorizationConfig.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -228,21 +228,21 @@ fun ByteArray.ensureMinSecretLength(algorithm: JWSAlgorithm): ByteArray {
228228
val secret = this
229229
when (algorithm) {
230230
JWSAlgorithm.HS512 -> {
231-
if (secret.size < 512) {
231+
if (secret.size * 8 < 512) {
232232
val digest = MessageDigest.getInstance("SHA-512")
233233
digest.update(secret)
234234
return digest.digest()
235235
}
236236
}
237237
JWSAlgorithm.HS384 -> {
238-
if (secret.size < 384) {
238+
if (secret.size * 8 < 384) {
239239
val digest = MessageDigest.getInstance("SHA-384")
240240
digest.update(secret)
241241
return digest.digest()
242242
}
243243
}
244244
JWSAlgorithm.HS256 -> {
245-
if (secret.size < 256) {
245+
if (secret.size * 8 < 256) {
246246
val digest = MessageDigest.getInstance("SHA-256")
247247
digest.update(secret)
248248
return digest.digest()

0 commit comments

Comments
 (0)