Skip to content

Commit 63da264

Browse files
author
Oleksandr Dzhychko
committed
feat(model-server)!: Use ENTRYPOINT instead of CMD in the provided Docker image
This follows best practices for Docker images. > You can use the exec form of ENTRYPOINT to set fairly stable default commands and arguments and then use either form of CMD to set additional defaults that are more likely to be changed. See https://docs.docker.com/engine/reference/builder/#exec-form-entrypoint-example Using a ENTRYPOINT in model-server docker container makes passing arguments easier. For example, `docker run modelix/model-server ./run-model-server.sh -inmemory` would be simplified to `docker run modelix/model-server -inmemory` BREAKING CHANGE: The previous entry point was the default `ENTRYPOINT ["/bin/sh", "-c"]`. Now it is `ENTRYPOINT ["./run-model-server.sh"]`. If you used `docker run modelix/model-server ./run-model-server.sh <args>` to pass arguments, you now have to use `docker run modelix/model-server <args>`. If you used any other process, you now have to override the entry point with the `--entrypoint` option. See https://docs.docker.com/engine/reference/run/#entrypoint-default-command-to-execute-at-runtime
1 parent 3d41891 commit 63da264

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

model-server/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ EXPOSE 28101
44
COPY run-model-server.sh /usr/modelix-model/
55
COPY build/dependency-libs/ /usr/modelix-model/model-server/build/libs/
66
COPY build/libs/ /usr/modelix-model/model-server/build/libs/
7-
CMD ["./run-model-server.sh"]
7+
ENTRYPOINT ["./run-model-server.sh"]

0 commit comments

Comments
 (0)