build: update to ESLint 9

With the update to v9, ESLint did not support reading configuration in subdirectories.
We relied on this feature when running ESLint with pre-commit.
Therefore, the configuration was unified at the top-level of the repository.
This resulted in a cleanup of linting related build code in the `ts-model-api` and `vue-model-api` directories.
The unification makes maintenance easier anyway.

The official ESLint hook is not used anymore because of the issue described in eslint/eslint#18465
The local hook works around that issue.
It also does not require duplicating versions of NPM packages.
But it requires installing NPM dependencies before running pre-commit hooks.

Author: Oleksandr Dzhychko

.github/workflows/linting.yml

@@ -8,6 +8,15 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20
+      - uses: actions/cache@v4
+        with:
+          path: node_modules
+          key: release-${{ hashFiles('package.json') }}-${{ hashFiles('package-lock.json') }}
+      - name: Install dependencies
+        run: npm ci
       - uses: actions/setup-python@v5
       - uses: pre-commit/[email protected]
 

.pre-commit-config.yaml

@@ -37,15 +37,11 @@ repos:
     hooks:
       - id: prettier
         files: ^(vue-model-api)|(model-api-gen-gradle-test/vue-integration)|(model-client-js-test/model-client-connection)/
-  - repo: https://github.com/pre-commit/mirrors-eslint
-    # IMPORTANT: keep versions of hook and additional dependencies in sync with the versions configured in `vue-model-api/package.json`
-    rev: v8.56.0
+  - repo: "local"
     hooks:
       - id: eslint
-        additional_dependencies:
-          - "[email protected]"
-          - "[email protected]"
-          - "@typescript-eslint/[email protected]"
-          - "@typescript-eslint/[email protected]"
-        files: ^(vue-model-api)|(ts-model-api)/src/
-        types: [ts]
+        name: ESLint
+        language: node
+        entry: npm
+        args: [ "run", "lint" ]
+        types: [ file ]

eslint.config.mjs

@@ -0,0 +1,49 @@
+import globals from "globals";
+import pluginJs from "@eslint/js";
+import tseslint from "typescript-eslint";
+import eslintConfigPrettier from "eslint-config-prettier";
+
+export default [
+  { files: ["**/*.{js,mjs,cjs,ts}"] },
+  { ignores: ["**/.gradle", "**/dist/", "**/build/"] },
+  {
+    languageOptions: {
+      ecmaVersion: "latest",
+      sourceType: "module",
+      globals: {
+          ...globals.browser,
+          ...globals.node,
+          ...globals.es2021
+      },
+    },
+  },
+  pluginJs.configs.recommended,
+  ...tseslint.configs.recommended,
+  eslintConfigPrettier, // > Turns off all rules that are unnecessary or might conflict with Prettier.
+  {
+    // The Redocly plugin uses CommonJS syntax for imports and exports as in the Redocly documentation.
+    files: ["model-server-openapi/**/*"],
+    rules: {
+      "@typescript-eslint/no-require-imports": "off"
+    }
+  },
+  {
+    rules: {
+      "@typescript-eslint/consistent-type-imports": "error",
+      "@typescript-eslint/no-import-type-side-effects": "error",
+      "@typescript-eslint/no-unused-vars": [
+        "error",
+        {
+          vars: "all",
+          args: "after-used",
+          varsIgnorePattern: "^_.+",
+          argsIgnorePattern: "^_.+",
+        },
+      ],
+      "@typescript-eslint/ban-ts-comment": [
+        "error",
+        { "ts-ignore": "allow-with-description" },
+      ],
+    },
+  },
+];