Skip to content

Commit 7c6b088

Browse files
committed
chore(model-server): use repeat instead of forEach
The affected blocks only repeat an action for a given number of times. Using repeat is the more direct phrasing of this action and avoid discussions about for loops vs. forEach.
1 parent 830a5d8 commit 7c6b088

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

model-server/src/test/kotlin/org/modelix/model/server/ReplicatedRepositoryTest.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ class ReplicatedRepositoryTest {
108108
}
109109
branchToChange.runWrite {
110110
val changeGenerator = RandomModelChangeGenerator(branchToChange.getRootNode(), rand)
111-
(1..1000).forEach { _ ->
111+
repeat(1000) { _ ->
112112
changeGenerator.applyRandomChange()
113113
}
114114
println("new tree: " + (branchToChange.transaction.tree as CLTree).hash)
@@ -153,7 +153,7 @@ class ReplicatedRepositoryTest {
153153
suspend fun launchWriter(model: ReplicatedModel, seed: Int) {
154154
launch {
155155
val rand = Random(seed)
156-
(1..10).forEach {
156+
repeat(10) {
157157
delay(rand.nextLong(50, 100))
158158
model.getBranch().runWriteT { t ->
159159
createdNodes += t.addNewChild(ITree.ROOT_ID, "role", -1, null as IConceptReference?).toString(16)
@@ -346,7 +346,7 @@ class ReplicatedRepositoryTest {
346346
suspend fun launchWriter(model: ReplicatedModel, seed: Int) {
347347
launch {
348348
val rand = Random(seed)
349-
(1..10).forEach {
349+
repeat(10) {
350350
delay(rand.nextLong(50, 100))
351351
model.getBranch().runWriteT { t ->
352352
createdNodes += t.addNewChild(ITree.ROOT_ID, "role", -1, null as IConceptReference?).toString(16)
@@ -361,7 +361,7 @@ class ReplicatedRepositoryTest {
361361
suspend fun launchWriterv1(model: ReplicatedRepository, seed: Int) {
362362
launch {
363363
val rand = Random(seed)
364-
(1..10).forEach {
364+
repeat(10) {
365365
delay(rand.nextLong(50, 100))
366366
model.branch.runWriteT { t ->
367367
createdNodes += t.addNewChild(ITree.ROOT_ID, "role", -1, null as IConceptReference?).toString(16)
@@ -439,7 +439,7 @@ class ReplicatedRepositoryTest {
439439
nonMergedVersions.remove(versionToMerge)
440440
}
441441

442-
(1..100).forEach {
442+
repeat(100) {
443443
val baseVersion = versions[rand.nextInt(versions.size)]
444444
val branch = OTBranch(PBranch(baseVersion.getTree(), idGenerator), idGenerator, initialTree.store)
445445
branch.runWriteT { t ->

0 commit comments

Comments
 (0)