chore(model-datastructure): throw NPE for consistency

mhuster23 · mhuster23 · commit 8b8e2f072dd9 · 2024-04-10T13:53:11.000+02:00
diff --git a/model-datastructure/src/commonMain/kotlin/org/modelix/model/lazy/CLTree.kt b/model-datastructure/src/commonMain/kotlin/org/modelix/model/lazy/CLTree.kt
@@ -257,7 +257,8 @@ class CLTree : ITree, IBulkTree {
     }
 
     override fun setConcept(nodeId: Long, concept: IConceptReference?): ITree {
-        val node = checkNotNull(resolveElement(nodeId)) { "nodeId could not be resolved. id=$nodeId" }
+        // manually throw NullPointerException for consistency, should be replaced for all methods in the future.
+        val node = resolveElement(nodeId) ?: throw NullPointerException("nodeId could not be resolved. id=$nodeId")
         val newData = create(
             node.id,
             concept?.getUID(),

Original file line number	Diff line number	Diff line change
`@@ -257,7 +257,8 @@ class CLTree : ITree, IBulkTree {`
`257`	`257`	`}`
`258`	`258`
`259`	`259`	`override fun setConcept(nodeId: Long, concept: IConceptReference?): ITree {`
`260`		`- val node = checkNotNull(resolveElement(nodeId)) { "nodeId could not be resolved. id=$nodeId" }`
	`260`	`+ // manually throw NullPointerException for consistency, should be replaced for all methods in the future.`
	`261`	`+ val node = resolveElement(nodeId) ?: throw NullPointerException("nodeId could not be resolved. id=$nodeId")`
`261`	`262`	`val newData = create(`
`262`	`263`	`node.id,`
`263`	`264`	`concept?.getUID(),`