fix(model-server): escape slashes in URL for branches and repositories

Author: Oleksandr Dzhychko

model-server/src/main/kotlin/org/modelix/model/server/handlers/RepositoryOverview.kt

@@ -1,11 +1,13 @@
 package org.modelix.model.server.handlers
 
+import io.ktor.http.encodeURLPathPart
 import io.ktor.server.application.Application
 import io.ktor.server.application.call
 import io.ktor.server.html.respondHtmlTemplate
 import io.ktor.server.routing.get
 import io.ktor.server.routing.routing
 import kotlinx.html.FlowContent
+import kotlinx.html.FlowOrInteractiveOrPhrasingContent
 import kotlinx.html.a
 import kotlinx.html.h1
 import kotlinx.html.i
@@ -74,9 +76,7 @@ class RepositoryOverview(private val repoManager: RepositoriesManager) {
                                         }
                                     }
                                     td {
-                                        a("../history/${branch.repositoryId.id}/${branch.branchName}/") {
-                                            +"Show History"
-                                        }
+                                        buildHistoryLink(branch.repositoryId.id, branch.branchName)
                                     }
                                     td {
                                         val latestVersion = repoManager.getVersion(branch)
@@ -94,3 +94,9 @@ class RepositoryOverview(private val repoManager: RepositoriesManager) {
         }
     }
 }
+
+fun FlowOrInteractiveOrPhrasingContent.buildHistoryLink(repositoryId: String, branchName: String) {
+    a("../history/${repositoryId.encodeURLPathPart()}/${branchName.encodeURLPathPart()}/") {
+        +"Show History"
+    }
+}

model-server/src/test/kotlin/org/modelix/model/server/handlers/RepositoryOverviewTest.kt

@@ -0,0 +1,33 @@
+/*
+ * Copyright (c) 2023.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.modelix.model.server.handlers
+
+import kotlinx.html.span
+import kotlinx.html.stream.createHTML
+import kotlin.test.Test
+import kotlin.test.assertEquals
+
+class RepositoryOverviewTest {
+
+    @Test
+    fun testSlashesInPathSegmentsFromRepositoryIdAndBranchId() {
+        val html = createHTML().span {
+            buildHistoryLink("repository/v1", "branch/v2")
+        }
+        assertEquals("<span><a href=\"../history/repository%2Fv1/branch%2Fv2/\">Show History</a></span>", html)
+    }
+}