fix(model-server): removed -useroleids flag

The /init endpoint now has a parameter instead.
ID based roles should be the default for new repositories anyway and the
parameter is not expected to be ever used.

Author: slisson

bulk-model-sync-gradle-test/build.gradle.kts

@@ -74,7 +74,6 @@ tasks.register("runModelServer", JavaExec::class) {
     classpath = sourceSets["main"].runtimeClasspath
     mainClass.set("org.modelix.model.server.Main")
     args("-inmemory")
-    args("-useroleids")
 }
 
 val resolveMps by tasks.registering(Copy::class) {

docs/global/modules/core/pages/reference/component-bulk-model-sync-gradle.adoc

@@ -12,8 +12,6 @@ https://github.com/modelix/modelix.core[Repository^] | https://github.com/modeli
 The `bulk-model-sync` Gradle plugin synchronizes models between `model-api` endpoints.
 A common example would be synchronizing a local MPS project to a `model-server`.
 
-IMPORTANT: For correct synchronization the used model-server is required to use IDs for roles. This can be achieved by starting the model-server with the `-useroleids` flag.
-
 .Bulk Synchronization between MPS and model-server
 image::bulk-model-sync-gradle.overview.png[Bulk Synchronization between MPS and model-server]
 

model-server/src/main/kotlin/org/modelix/model/server/CmdLineArgs.kt

@@ -40,9 +40,6 @@ internal class CmdLineArgs {
     )
     var schemaInit = false
 
-    @Parameter(names = ["-useroleids"], description = "Use IDs for roles instead of simpleNames. Required for bulk sync.", converter = BooleanConverter::class)
-    var useRoleIds = false
-
     @Parameter(names = ["-h", "--help"], help = true)
     var help = false
 }

model-server/src/main/kotlin/org/modelix/model/server/Main.kt

@@ -151,7 +151,7 @@ object Main {
             }
 
             val jsonModelServer = DeprecatedLightModelServer(localModelClient)
-            val repositoriesManager = RepositoriesManager(localModelClient, cmdLineArgs.useRoleIds)
+            val repositoriesManager = RepositoriesManager(localModelClient)
             val repositoryOverview = RepositoryOverview(repositoriesManager)
             val historyHandler = HistoryHandler(localModelClient, repositoriesManager)
             val contentExplorer = ContentExplorer(localModelClient, repositoriesManager)

model-server/src/main/kotlin/org/modelix/model/server/handlers/ModelReplicationServer.kt

@@ -103,7 +103,8 @@ class ModelReplicationServer(val repositoriesManager: RepositoriesManager) {
                 fun ApplicationCall.repositoryId() = RepositoryId(parameters["repository"]!!)
                 fun PipelineContext<Unit, ApplicationCall>.repositoryId() = call.repositoryId()
                 post("init") {
-                    val initialVersion = repositoriesManager.createRepository(repositoryId(), call.getUserName())
+                    val useRoleIds = call.request.queryParameters["useRoleIds"] != "false"
+                    val initialVersion = repositoriesManager.createRepository(repositoryId(), call.getUserName(), useRoleIds)
                     call.respondDelta(initialVersion.getContentHash(), null)
                 }
                 route("branches") {

model-server/src/main/kotlin/org/modelix/model/server/handlers/RepositoriesManager.kt

@@ -30,7 +30,7 @@ import org.modelix.model.server.store.IStoreClient
 import org.modelix.model.server.store.LocalModelClient
 import org.modelix.model.server.store.pollEntry
 
-class RepositoriesManager(val client: LocalModelClient, val useRoleIds: Boolean = false) {
+class RepositoriesManager(val client: LocalModelClient) {
     init {
         migrateLegacyRepositoriesList()
     }
@@ -45,7 +45,7 @@ class RepositoriesManager(val client: LocalModelClient, val useRoleIds: Boolean
         return store[REPOSITORIES_LIST_KEY]?.lines()?.map { RepositoryId(it) }?.toSet() ?: emptySet()
     }
 
-    fun createRepository(repositoryId: RepositoryId, userName: String?): CLVersion {
+    fun createRepository(repositoryId: RepositoryId, userName: String?, useRoleIds: Boolean = true): CLVersion {
         var initialVersion: CLVersion? = null
         store.runTransaction {
             val masterBranch = repositoryId.getBranchReference()