fix(model-datastructure): role IDs are now used by default

Name based persistence is considered legacy and should not be used for
new models. To avoid accidental use of this legacy persistence all
default values where changed to `true`.

BREAKING CHANGE: The default value for `useRoleIds` parameters changed
to true. If you didn't specify a value for `useRoleIds` and rely on a
name based persistence you now have to provide an explicit `false`
value.

Author: slisson

model-client/src/commonMain/kotlin/org/modelix/model/ModelFacade.kt

@@ -24,7 +24,7 @@ import kotlin.jvm.JvmOverloads
 object ModelFacade {
 
     @JvmOverloads
-    fun newLocalTree(useRoleIds: Boolean = false): ITree {
+    fun newLocalTree(useRoleIds: Boolean = true): ITree {
         return CLTree(ObjectStoreCache(MapBaseStore()), useRoleIds = useRoleIds)
     }
 

model-client/src/commonMain/kotlin/org/modelix/model/client2/ModelClientV2.kt

@@ -155,10 +155,10 @@ class ModelClientV2(
     }
 
     override suspend fun initRepositoryWithLegacyStorage(repository: RepositoryId): IVersion {
-        return initRepository(repository, useRoleIds = false, legacyGlobalStorage = true)
+        return initRepository(repository, useRoleIds = true, legacyGlobalStorage = true)
     }
 
-    suspend fun initRepository(repository: RepositoryId, useRoleIds: Boolean = false, legacyGlobalStorage: Boolean = false): IVersion {
+    suspend fun initRepository(repository: RepositoryId, useRoleIds: Boolean = true, legacyGlobalStorage: Boolean = false): IVersion {
         return httpClient.preparePost {
             url {
                 parameter("useRoleIds", useRoleIds)

model-datastructure/src/commonMain/kotlin/org/modelix/model/lazy/CLTree.kt

@@ -62,7 +62,7 @@ fun createNewTreeData(
 
 class CLTree(val data: CPTree, val asyncStore: IAsyncObjectStore) : ITree by AsyncAsSynchronousTree(AsyncTree(data, asyncStore)), IBulkTree {
 
-    constructor(store: IAsyncObjectStore, useRoleIds: Boolean = false) : this(createNewTreeData(store, useRoleIds = useRoleIds), store)
+    constructor(store: IAsyncObjectStore, useRoleIds: Boolean = true) : this(createNewTreeData(store, useRoleIds = useRoleIds), store)
     constructor(store: IDeserializingKeyValueStore, useRoleIds: Boolean = true) : this(store.getAsyncStore(), useRoleIds)
     constructor(data: CPTree, store: IDeserializingKeyValueStore) : this(data, store.getAsyncStore())
 
@@ -153,7 +153,7 @@ class CLTree(val data: CPTree, val asyncStore: IAsyncObjectStore) : ITree by Asy
 
     class Builder(var store: IAsyncObjectStore) {
         private var repositoryId: RepositoryId? = null
-        private var useRoleIds: Boolean = false
+        private var useRoleIds: Boolean = true
 
         fun useRoleIds(value: Boolean = true): Builder {
             this.useRoleIds = value