fix(model-server): add force-reload after repository deletion

Author: mhuster23

model-server/src/main/kotlin/org/modelix/model/server/handlers/ui/RepositoryOverview.kt

@@ -10,12 +10,10 @@ import kotlinx.html.FlowContent
 import kotlinx.html.FlowOrInteractiveOrPhrasingContent
 import kotlinx.html.a
 import kotlinx.html.button
-import kotlinx.html.form
 import kotlinx.html.h1
 import kotlinx.html.i
 import kotlinx.html.onClick
 import kotlinx.html.p
-import kotlinx.html.postButton
 import kotlinx.html.script
 import kotlinx.html.span
 import kotlinx.html.table
@@ -42,11 +40,18 @@ class RepositoryOverview(private val repoManager: IRepositoriesManager) {
                             unsafe {
                                 +"""
                                     function removeBranch(repository, branch) {
-                                        if (confirm('Are you sure you want to delete the branch' + branch +' of repository' +repository + '?')) {
+                                        if (confirm('Are you sure you want to delete the branch ' + branch + ' of repository ' +repository + '?')) {
                                             fetch('../v2/repositories/' + repository + '/branches/' + branch, { method: 'DELETE'})
                                             .then( _ => location.reload())
                                         }
                                     }
+
+                                    function removeRepository(repository) {
+                                        if (confirm('Are you sure you want to delete the repository ' + repository + '?')) {
+                                            fetch('../v2/repositories/' + repository + '/delete', { method: 'POST'})
+                                            .then( _ => location.reload())
+                                        }
+                                    }
                                 """.trimIndent()
                             }
                         }
@@ -138,13 +143,11 @@ internal fun FlowOrInteractiveOrPhrasingContent.buildExploreLatestLink(repositor
 }
 
 internal fun FlowContent.buildDeleteRepositoryForm(repositoryId: String) {
-    form {
-        postButton {
-            name = "delete"
-            formAction = "../v2/repositories/${repositoryId.encodeURLPathPart()}/delete"
-            onClick = "return confirm('Are you sure you want to delete the repository $repositoryId?')"
-            +"Delete Repository"
-        }
+    button {
+        name = "delete"
+        formAction = "../v2/repositories/${repositoryId.encodeURLPathPart()}/delete"
+        onClick = "return removeRepository('${repositoryId.encodeURLPathPart()}')"
+        +"Delete Repository"
     }
 }
 

model-server/src/test/kotlin/org/modelix/model/server/handlers/ui/RepositoryOverviewTest.kt

@@ -47,14 +47,14 @@ class RepositoryOverviewTest {
     }
 
     @Test
-    fun `delete repository form action is encoded properly`() {
+    fun `delete repository button parameters encoded properly`() {
         val html = createHTML(prettyPrint = false).span {
             buildDeleteRepositoryForm("repository/v1")
         }
 
         val document = Jsoup.parse(html)
-        val formAction = document.getElementsByTag("button").first()?.attribute("formaction")?.value
-        assertEquals("../v2/repositories/repository%2Fv1/delete", formAction)
+        val onClick = document.getElementsByTag("button").first()?.attribute("onclick")?.value
+        assertEquals("return removeRepository('repository%2Fv1')", onClick)
     }
 
     @Test