fix(model-client): implement tests for the deleteRepository method of ModelClientV2

Author: benedekh

model-client/src/commonMain/kotlin/org/modelix/model/client2/ModelClientV2.kt

@@ -141,12 +141,17 @@ class ModelClientV2(
     }
 
     override suspend fun deleteRepository(repository: RepositoryId): Boolean {
-        return httpClient.post {
-            url {
-                takeFrom(baseUrl)
-                appendPathSegmentsEncodingSlash("repositories", repository.id, "delete")
-            }
-        }.status == HttpStatusCode.NoContent
+        try {
+            return httpClient.post {
+                url {
+                    takeFrom(baseUrl)
+                    appendPathSegmentsEncodingSlash("repositories", repository.id, "delete")
+                }
+            }.status == HttpStatusCode.NoContent
+        } catch (ex: Exception) {
+            LOG.error(ex) { ex.message }
+            return false
+        }
     }
 
     override suspend fun listBranches(repository: RepositoryId): List<BranchReference> {

model-server/src/test/kotlin/org/modelix/model/server/ModelClientV2Test.kt

@@ -36,6 +36,7 @@ import org.modelix.model.server.handlers.ModelReplicationServer
 import org.modelix.model.server.store.InMemoryStoreClient
 import org.modelix.modelql.core.count
 import org.modelix.modelql.untyped.allChildren
+import java.util.UUID
 import kotlin.test.Test
 import kotlin.test.assertEquals
 
@@ -154,4 +155,30 @@ class ModelClientV2Test {
 
         assertEquals("localhost", modelClient.getUserId())
     }
+
+    @Test
+    fun `newly created repository can be removed`() = runTest {
+        val url = "http://localhost/v2"
+        val client = ModelClientV2.builder().url(url).client(client).build().also { it.init() }
+        val repositoryId = RepositoryId(UUID.randomUUID().toString())
+        client.initRepository(repositoryId)
+
+        val success = client.deleteRepository(repositoryId)
+
+        assertEquals(true, success)
+    }
+
+    @Test
+    fun `non-existing repository cannot be removed`() = runTest {
+        val url = "http://localhost/v2"
+        val client = ModelClientV2.builder().url(url).client(client).build().also { it.init() }
+        val repositoryId = RepositoryId(UUID.randomUUID().toString())
+        client.initRepository(repositoryId)
+
+        client.deleteRepository(repositoryId)
+        // repository should not exist here
+        val success = client.deleteRepository(repositoryId)
+
+        assertEquals(false, success)
+    }
 }