Skip to content

Commit f4077bc

Browse files
languitarlanguitar
committed
test(model-datastructure): drop long-running test
The `knownPerformanceIssue` test case was now constantly timing out when being executed in JS. After clarification, all corner cases it included are already covered by the remaining tests in the test file and also by MergeOrderTest, ConflictResolutionTest, and UndoTest. Therefore, I have dropped this test case to avoid the timeout and to reduce the amount of hard to maintain test cases. The expensive part about the test was the way assertHistoryIsCorrect was implemented, not the production code.
1 parent 5cc9c2c commit f4077bc

File tree

1 file changed

+0
-127
lines changed

1 file changed

+0
-127
lines changed

‎model-datastructure/src/commonTest/kotlin/LinearHistoryTest.kt‎

Lines changed: 0 additions & 127 deletions
Original file line numberDiff line numberDiff line change
@@ -57,133 +57,6 @@ class LinearHistoryTest {
5757
assertEquals(expected, actual)
5858
}
5959

60-
@Test
61-
fun knownPerformanceIssue() {
62-
// This test was dumped from actual case discovered during a profiling session.
63-
64-
val v30000003a = version(12884901946, null)
65-
val v1000004d1 = version(4294968529, v30000003a)
66-
val v1000004d3 = version(4294968531, v1000004d1)
67-
val v200000353 = version(8589935443, v1000004d3)
68-
val v1000004d5 = version(4294968533, v1000004d3)
69-
val v30000003c = merge(12884901948, v1000004d3, v200000353, v1000004d5)
70-
val v1000004d6 = merge(4294968534, v1000004d3, v1000004d5, v200000353)
71-
val v30000003d = merge(12884901949, v1000004d3, v30000003c, v1000004d6)
72-
val v30000003e = merge(12884901950, v1000004d3, v30000003d, v1000004d6)
73-
val v200000354 = merge(8589935444, v1000004d3, v200000353, v30000003d)
74-
val v30000003f = merge(12884901951, v1000004d3, v30000003e, v200000354)
75-
val v300000040 = merge(12884901952, v1000004d3, v30000003f, v200000354)
76-
val v200000356 = version(8589935446, v200000354)
77-
val v300000041 = merge(12884901953, v1000004d3, v300000040, v200000356)
78-
val v1000004d8 = version(4294968536, v1000004d6)
79-
val v300000042 = merge(12884901954, v1000004d3, v300000041, v1000004d8)
80-
val v1000004d9 = merge(4294968537, v1000004d3, v1000004d8, v300000041)
81-
val v300000043 = merge(12884901955, v1000004d3, v300000042, v1000004d9)
82-
val v300000044 = merge(12884901956, v1000004d3, v300000043, v1000004d9)
83-
val v200000357 = merge(8589935447, v1000004d3, v200000356, v300000041)
84-
val v300000045 = merge(12884901957, v1000004d3, v300000044, v200000357)
85-
val v300000046 = merge(12884901958, v1000004d3, v300000045, v200000357)
86-
val v1000004da = merge(4294968538, v1000004d3, v1000004d9, v300000046)
87-
val v300000047 = merge(12884901959, v1000004d3, v300000046, v1000004da)
88-
val v300000048 = merge(12884901960, v1000004d3, v300000047, v1000004da)
89-
val v200000359 = version(8589935449, v200000357)
90-
val v300000049 = merge(12884901961, v1000004d3, v300000048, v200000359)
91-
val v1000004dc = version(4294968540, v1000004da)
92-
val v30000004a = merge(12884901962, v1000004d3, v300000049, v1000004dc)
93-
val v20000035a = merge(8589935450, v1000004d3, v200000359, v300000046)
94-
val v30000004b = merge(12884901963, v1000004d3, v30000004a, v20000035a)
95-
val v30000004c = merge(12884901964, v1000004d3, v30000004b, v20000035a)
96-
val v1000004dd = merge(4294968541, v1000004d3, v1000004dc, v30000004c)
97-
val v30000004d = merge(12884901965, v1000004d3, v30000004c, v1000004dd)
98-
val v30000004e = merge(12884901966, v1000004d3, v30000004d, v1000004dd)
99-
val v20000035b = merge(8589935451, v1000004d3, v20000035a, v30000004c)
100-
val v30000004f = merge(12884901967, v1000004d3, v30000004e, v20000035b)
101-
val v300000050 = merge(12884901968, v1000004d3, v30000004f, v20000035b)
102-
val v1000004df = version(4294968543, v1000004dd)
103-
val v300000051 = merge(12884901969, v1000004d3, v300000050, v1000004df)
104-
val v20000035d = version(8589935453, v20000035b)
105-
val v300000052 = merge(12884901970, v1000004d3, v300000051, v20000035d)
106-
val v1000004e0 = merge(4294968544, v1000004d3, v1000004df, v300000051)
107-
val v300000053 = merge(12884901971, v1000004d3, v300000052, v1000004e0)
108-
val v300000054 = merge(12884901972, v1000004d3, v300000053, v1000004e0)
109-
val v20000035f = version(8589935455, v20000035d)
110-
val v300000055 = merge(12884901973, v1000004d3, v300000054, v20000035f)
111-
val v200000360 = merge(8589935456, v1000004d3, v20000035f, v300000052)
112-
val v300000056 = merge(12884901974, v1000004d3, v300000055, v200000360)
113-
val v300000057 = merge(12884901975, v1000004d3, v300000056, v200000360)
114-
val v1000004e2 = version(4294968546, v1000004e0)
115-
val v300000058 = merge(12884901976, v1000004d3, v300000057, v1000004e2)
116-
val v200000362 = version(8589935458, v200000360)
117-
val v300000059 = merge(12884901977, v1000004d3, v300000058, v200000362)
118-
val v1000004e3 = merge(4294968547, v1000004d3, v1000004e2, v300000058)
119-
val v30000005a = merge(12884901978, v1000004d3, v300000059, v1000004e3)
120-
val v30000005b = merge(12884901979, v1000004d3, v30000005a, v1000004e3)
121-
val v1000004e5 = version(4294968549, v1000004e3)
122-
val v30000005c = merge(12884901980, v1000004d3, v30000005b, v1000004e5)
123-
val v200000363 = merge(8589935459, v1000004d3, v200000362, v300000058)
124-
val v30000005d = merge(12884901981, v1000004d3, v30000005c, v200000363)
125-
val v30000005e = merge(12884901982, v1000004d3, v30000005d, v200000363)
126-
val v200000365 = version(8589935461, v200000363)
127-
val v30000005f = merge(12884901983, v1000004d3, v30000005e, v200000365)
128-
val v1000004e7 = version(4294968551, v1000004e5)
129-
val v300000060 = merge(12884901984, v1000004d3, v30000005f, v1000004e7)
130-
val v200000367 = version(8589935463, v200000365)
131-
val v300000061 = merge(12884901985, v1000004d3, v300000060, v200000367)
132-
val v1000004e9 = version(4294968553, v1000004e7)
133-
val v300000062 = merge(12884901986, v1000004d3, v300000061, v1000004e9)
134-
val v1000004ea = merge(4294968554, v1000004d3, v1000004e9, v300000060)
135-
val v300000063 = merge(12884901987, v1000004d3, v300000062, v1000004ea)
136-
val v300000064 = merge(12884901988, v1000004d3, v300000063, v1000004ea)
137-
val v200000369 = version(8589935465, v200000367)
138-
val v300000065 = merge(12884901989, v1000004d3, v300000064, v200000369)
139-
val v20000036a = merge(8589935466, v1000004d3, v200000369, v300000060)
140-
val v300000066 = merge(12884901990, v1000004d3, v300000065, v20000036a)
141-
val v1000004eb = merge(4294968555, v1000004d3, v1000004ea, v300000061)
142-
val v300000067 = merge(12884901991, v1000004d3, v300000066, v1000004eb)
143-
val v20000036c = version(8589935468, v20000036a)
144-
val v300000068 = merge(12884901992, v1000004d3, v300000067, v20000036c)
145-
val v300000069 = merge(12884901993, v1000004d3, v300000068, v20000036a)
146-
val v30000006b = merge(12884901995, v1000004d3, v300000069, v1000004eb)
147-
val v20000036d = merge(8589935469, v1000004d3, v20000036c, v300000063)
148-
val v30000006c = merge(12884901996, v1000004d3, v30000006b, v20000036d)
149-
val v30000006d = merge(12884901997, v1000004d3, v30000006c, v20000036d)
150-
val v1000004ec = merge(4294968556, v1000004d3, v1000004eb, v30000006c)
151-
val v30000006e = merge(12884901998, v1000004d3, v30000006d, v1000004ec)
152-
val v300000070 = merge(12884902000, v1000004d3, v30000006e, v1000004ec)
153-
val v20000036e = merge(8589935470, v1000004d3, v20000036d, v30000006e)
154-
val v300000071 = merge(12884902001, v1000004d3, v300000070, v20000036e)
155-
val v1000004ed = merge(4294968557, v1000004d3, v1000004ec, v30000006e)
156-
val v300000072 = merge(12884902002, v1000004d3, v300000071, v1000004ed)
157-
val v20000036f = merge(8589935471, v1000004d3, v20000036e, v30000006e)
158-
val v300000073 = merge(12884902003, v1000004d3, v300000072, v20000036f)
159-
val v300000074 = merge(12884902004, v1000004d3, v300000073, v20000036f)
160-
val v300000075 = merge(12884902005, v1000004d3, v300000074, v20000036e)
161-
val v1000004ee = merge(4294968558, v1000004d3, v30000006e, v300000075)
162-
163-
// val expected = SlowLinearHistory(v1000004d3.getContentHash()).load(v300000075, v1000004ee)
164-
val expected = listOf(
165-
v1000004d5,
166-
v200000353,
167-
v1000004d8,
168-
v200000356,
169-
v200000359,
170-
v1000004dc,
171-
v1000004df,
172-
v20000035d,
173-
v20000035f,
174-
v1000004e2,
175-
v200000362,
176-
v1000004e5,
177-
v1000004e7,
178-
v1000004e9,
179-
v200000365,
180-
v200000367,
181-
v200000369,
182-
v20000036c,
183-
)
184-
assertHistory(v300000075, v1000004ee, expected)
185-
}
186-
18760
@Test
18861
fun correctHistoryIfIdsAreNotAscending() {
18962
val v1 = version(1, null)

0 commit comments

Comments
 (0)