fix: check tag or digest before remove the manifest (#116)

Signed-off-by: chlins <[email protected]>

Author: chlins

go.mod

@@ -12,6 +12,7 @@ require (
 	github.com/minio/sha256-simd v1.0.1
 	github.com/opencontainers/go-digest v1.0.0
 	github.com/opencontainers/image-spec v1.1.0
+	github.com/sirupsen/logrus v1.9.3
 	github.com/spf13/cobra v1.9.1
 	github.com/spf13/viper v1.19.0
 	github.com/stretchr/testify v1.10.0
@@ -56,7 +57,6 @@ require (
 	github.com/rivo/uniseg v0.4.7 // indirect
 	github.com/sagikazarmark/locafero v0.6.0 // indirect
 	github.com/sagikazarmark/slog-shim v0.1.0 // indirect
-	github.com/sirupsen/logrus v1.9.3 // indirect
 	github.com/sourcegraph/conc v0.3.0 // indirect
 	github.com/spf13/afero v1.11.0 // indirect
 	github.com/spf13/cast v1.7.0 // indirect

pkg/backend/rm.go

@@ -36,6 +36,10 @@ func (b *backend) Remove(ctx context.Context, target string) (string, error) {
 		reference = ref.Digest()
 	}
 
+	if reference == "" {
+		return "", fmt.Errorf("invalid reference, tag or digest must be provided")
+	}
+
 	if err := b.store.DeleteManifest(ctx, repo, reference); err != nil {
 		return "", fmt.Errorf("failed to delete manifest %s: %w", reference, err)
 	}

pkg/storage/distribution/distribution.go

@@ -30,6 +30,7 @@ import (
 	sha256 "github.com/minio/sha256-simd"
 	godigest "github.com/opencontainers/go-digest"
 	ocispec "github.com/opencontainers/image-spec/specs-go/v1"
+	"github.com/sirupsen/logrus"
 )
 
 func init() {
@@ -55,6 +56,9 @@ type storage struct {
 }
 
 func NewStorage(rootDir string) (*storage, error) {
+	// Mute the logging from distribution.
+	logrus.SetOutput(io.Discard)
+
 	fsDriver := filesystem.New(filesystem.DriverParameters{
 		RootDirectory: rootDir,
 		MaxThreads:    defaultMaxThreads,