refactor: remove nydusify logic from backend

Signed-off-by: chlins <[email protected]>

Author: chlins

cmd/attach.go

@@ -19,9 +19,7 @@ package cmd
 import (
 	"context"
 	"fmt"
-	"time"
 
-	"github.com/briandowns/spinner"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 
@@ -80,21 +78,5 @@ func runAttach(ctx context.Context, filepath string) error {
 
 	fmt.Printf("Successfully attached model artifact: %s\n", attachConfig.Target)
 
-	// nydusify the model artifact if needed.
-	if attachConfig.Nydusify {
-		sp := spinner.New(spinner.CharSets[39], 100*time.Millisecond, spinner.WithSuffix("Nydusifying..."))
-		sp.Start()
-		defer sp.Stop()
-
-		nydusName, err := b.Nydusify(ctx, attachConfig.Target)
-		if err != nil {
-			err = fmt.Errorf("failed to nydusify %s: %w", attachConfig.Target, err)
-			sp.FinalMSG = err.Error()
-			return err
-		}
-
-		sp.FinalMSG = fmt.Sprintf("Successfully nydusify model artifact: %s", nydusName)
-	}
-
 	return nil
 }

cmd/build.go

@@ -19,11 +19,9 @@ package cmd
 import (
 	"context"
 	"fmt"
-	"time"
 
 	"github.com/CloudNativeAI/modctl/pkg/backend"
 	"github.com/CloudNativeAI/modctl/pkg/config"
-	"github.com/briandowns/spinner"
 
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
@@ -82,21 +80,5 @@ func runBuild(ctx context.Context, workDir string) error {
 
 	fmt.Printf("Successfully built model artifact: %s\n", buildConfig.Target)
 
-	// nydusify the model artifact if needed.
-	if buildConfig.Nydusify {
-		sp := spinner.New(spinner.CharSets[39], 100*time.Millisecond, spinner.WithSuffix("Nydusifying..."))
-		sp.Start()
-		defer sp.Stop()
-
-		nydusName, err := b.Nydusify(ctx, buildConfig.Target)
-		if err != nil {
-			err = fmt.Errorf("failed to nydusify %s: %w", buildConfig.Target, err)
-			sp.FinalMSG = err.Error()
-			return err
-		}
-
-		sp.FinalMSG = fmt.Sprintf("Successfully nydusify model artifact: %s", nydusName)
-	}
-
 	return nil
 }

cmd/push.go

@@ -19,12 +19,10 @@ package cmd
 import (
 	"context"
 	"fmt"
-	"time"
 
 	"github.com/CloudNativeAI/modctl/pkg/backend"
 	"github.com/CloudNativeAI/modctl/pkg/config"
 
-	"github.com/briandowns/spinner"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 )
@@ -75,21 +73,5 @@ func runPush(ctx context.Context, target string) error {
 
 	fmt.Printf("Successfully pushed model artifact: %s\n", target)
 
-	// nydusify the model artifact if needed.
-	if pushConfig.Nydusify {
-		sp := spinner.New(spinner.CharSets[39], 100*time.Millisecond, spinner.WithSuffix("Nydusifying..."))
-		sp.Start()
-		defer sp.Stop()
-
-		nydusName, err := b.Nydusify(ctx, target)
-		if err != nil {
-			err = fmt.Errorf("failed to nydusify %s: %w", target, err)
-			sp.FinalMSG = err.Error()
-			return err
-		}
-
-		sp.FinalMSG = fmt.Sprintf("Successfully nydusify model artifact: %s", nydusName)
-	}
-
 	return nil
 }

pkg/backend/attach.go

@@ -35,7 +35,6 @@ import (
 	"github.com/CloudNativeAI/modctl/pkg/backend/build"
 	buildconfig "github.com/CloudNativeAI/modctl/pkg/backend/build/config"
 	"github.com/CloudNativeAI/modctl/pkg/backend/build/hooks"
-	"github.com/CloudNativeAI/modctl/pkg/backend/build/interceptor"
 	"github.com/CloudNativeAI/modctl/pkg/backend/processor"
 	"github.com/CloudNativeAI/modctl/pkg/backend/remote"
 	"github.com/CloudNativeAI/modctl/pkg/config"
@@ -349,9 +348,6 @@ func (b *backend) getBuilder(reference string, cfg *config.Attach) (build.Builde
 		build.WithPlainHTTP(cfg.PlainHTTP),
 		build.WithInsecure(cfg.Insecure),
 	}
-	if cfg.Nydusify {
-		opts = append(opts, build.WithInterceptor(interceptor.NewNydus()))
-	}
 
 	builder, err := build.NewBuilder(outputType, b.store, repo, tag, opts...)
 	if err != nil {

pkg/backend/backend.go

@@ -66,9 +66,6 @@ type Backend interface {
 
 	// Tag creates a new tag that refers to the source model artifact.
 	Tag(ctx context.Context, source, target string) error
-
-	// Nydusify converts the model artifact to nydus format.
-	Nydusify(ctx context.Context, target string) (string, error)
 }
 
 // backend is the implementation of Backend.

pkg/backend/build.go

@@ -32,7 +32,6 @@ import (
 	"github.com/CloudNativeAI/modctl/pkg/backend/build"
 	buildconfig "github.com/CloudNativeAI/modctl/pkg/backend/build/config"
 	"github.com/CloudNativeAI/modctl/pkg/backend/build/hooks"
-	"github.com/CloudNativeAI/modctl/pkg/backend/build/interceptor"
 	"github.com/CloudNativeAI/modctl/pkg/backend/processor"
 	"github.com/CloudNativeAI/modctl/pkg/config"
 	"github.com/CloudNativeAI/modctl/pkg/modelfile"
@@ -78,9 +77,6 @@ func (b *backend) Build(ctx context.Context, modelfilePath, workDir, target stri
 		build.WithPlainHTTP(cfg.PlainHTTP),
 		build.WithInsecure(cfg.Insecure),
 	}
-	if cfg.Nydusify {
-		opts = append(opts, build.WithInterceptor(interceptor.NewNydus()))
-	}
 
 	builder, err := build.NewBuilder(outputType, b.store, repo, tag, opts...)
 	if err != nil {