Modctl is still using legacy dependency github.com/dragonflyoss/model-spec in various places

[amisevsk]

The legacy dependency github.com/dragonflyoss/model-spec v0.0.6 is still used in various places in this project. While this makes sense in some cases (e.g. checking for older model-spec artifacts), it is also used as the default modelspec package for the modctl build operation.

This results in artifacts created by current versions of modctl still using older application/vnd.cnai.model.* mediatypes and annotations, which are currently outside of the model-spec.

This is also reflected in tests for modctl, which still check for the vnd.cnai* mediatypes and annotations, despite the project depending on model-spec v0.0.7

[chlins]

Yes, this behavior is currently known. The background here is that the older versions of the model spec have already been used for building and, in actual production environments, model images based on these older specs are widely used. In order to ensure compatibility with these historical images, we have to support both the old and new versions simultaneously. Of course, after a few version cycles, the new model spec should ultimately become the default implementation.

[amisevsk]

I understand the reasoning behind it -- however the current usage results in new modelpacks generated by modctl still using the old mediatypes; if the goal is to use the new model spec (application/vnd.cncf.model.*), then we need to first stop generating artifacts that use the old media types.

[chlins]

I understand the reasoning behind it -- however the current usage results in new modelpacks generated by modctl still using the old mediatypes; if the goal is to use the new model spec (application/vnd.cncf.model.*), then we need to first stop generating artifacts that use the old media types.

Sure, currently the v0.1.x version is a transitional version, and will switch to the latest model spec in v0.2.x.