controller: fix handling for invalid node name (#20)

If the model PVC is already in a bound state but the node hosting it
has been taken offline, the previous delete volume process would trust
the node IP marked on the PV, but since the node no longer exists,
gRPC request sent via that node IP would fail, and then preventing the
PV from being deleted.

This fix ensures that during each delete volume operation, we check the
node status, if the node no longer exists, we return success directly,
allowing the orphaned PV to be cleaned up properly.

Signed-off-by: imeoer <yansong.ys@antgroup.com>

Author: imeoer

pkg/service/controller_remote.go

@@ -15,6 +15,7 @@ import (
 	"google.golang.org/grpc/keepalive"
 	"google.golang.org/grpc/metadata"
 	"google.golang.org/grpc/status"
+	apierrors "k8s.io/apimachinery/pkg/api/errors"
 
 	"github.com/container-storage-interface/spec/lib/go/csi"
 	"github.com/modelpack/model-csi-driver/pkg/logger"
@@ -139,24 +140,26 @@ func (s *Service) remoteDeleteVolume(
 		parameters = map[string]string{}
 	}
 
-	nodeIP := parameters[s.cfg.Get().ParameterVolumeContextNodeIP()]
-	if nodeIP == "" {
-		nodeName := parameters[annotationSelectedNode]
-		if nodeName == "" {
-			return nil, status.Errorf(codes.InvalidArgument, "empty annotation %s in PVC", annotationSelectedNode)
-		}
-		_, span := tracing.Tracer.Start(ctx, "GetNodeInfoByName")
-		span.SetAttributes(attribute.String("node_name", nodeName))
-		nodeInfo, err := s.getNodeInfoByName(ctx, nodeName)
-		if err != nil {
-			span.SetStatus(otelCodes.Error, "failed to get node info")
-			span.RecordError(err)
-			span.End()
-			return nil, errors.Wrapf(err, "get node IP by name: %s", nodeName)
-		}
+	nodeName := parameters[annotationSelectedNode]
+	if nodeName == "" {
+		return nil, status.Errorf(codes.InvalidArgument, "empty annotation %s in PVC", annotationSelectedNode)
+	}
+	_, span := tracing.Tracer.Start(ctx, "GetNodeInfoByName")
+	span.SetAttributes(attribute.String("node_name", nodeName))
+	nodeInfo, err := s.getNodeInfoByName(ctx, nodeName)
+	if err != nil {
+		span.SetStatus(otelCodes.Error, "failed to get node info")
+		span.RecordError(err)
 		span.End()
-		nodeIP = nodeInfo.ip
+		// If node not found, we just return success to avoid orphaned volume.
+		if apierrors.IsNotFound(err) {
+			logger.WithContext(ctx).WithError(err).Warnf("node %s not found, return success for deleting volume", nodeName)
+			return &csi.DeleteVolumeResponse{}, nil
+		}
+		return nil, errors.Wrapf(err, "get node IP by name: %s", nodeName)
 	}
+	span.End()
+	nodeIP := nodeInfo.ip
 
 	volumeID := req.GetVolumeId()
 	if volumeID == "" {