Skip to content

Commit 6dba669

Browse files
committed
Refactor monitor module for improved structure and readability
1 parent 103c403 commit 6dba669

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

tests/utils/swanlab_test.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,7 @@
55
class TestSwanlabMonitor(unittest.TestCase):
66
@classmethod
77
def setUpClass(cls):
8-
# Ensure an env-based key path is exercised (uses dummy if not provided)
9-
cls.env_keys = ["SWANLAB_API_KEY", "SWANLAB_APIKEY", "SWANLAB_KEY", "SWANLAB_TOKEN"]
10-
cls._original_env = {k: os.environ.get(k) for k in cls.env_keys}
11-
if not any(os.getenv(k) for k in cls.env_keys):
12-
os.environ["SWANLAB_API_KEY"] = "dummy_key_for_smoke_test"
8+
os.environ["SWANLAB_API_KEY"] = "xxxxxxxxxxxxxxxxxxxxx"
139

1410
@classmethod
1511
def tearDownClass(cls):

trinity/utils/monitor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
"tensorboard": "trinity.utils.monitor.TensorboardMonitor",
3535
"wandb": "trinity.utils.monitor.WandbMonitor",
3636
"mlflow": "trinity.utils.monitor.MlflowMonitor",
37+
"swanlab": "trinity.utils.monitor.SwanlabMonitor",
3738
},
3839
)
3940

@@ -240,7 +241,6 @@ def default_args(cls) -> Dict:
240241
}
241242

242243

243-
@MONITOR.register_module("swanlab")
244244
class SwanlabMonitor(Monitor):
245245
"""Monitor with SwanLab.
246246

0 commit comments

Comments
 (0)