Skip to content

Commit a0f62f9

Browse files
committed
* make sure the servers work
1 parent 54a4721 commit a0f62f9

File tree

7 files changed

+22
-8
lines changed

7 files changed

+22
-8
lines changed

environments/data.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@ dependencies:
55
- python=3.10
66
- pip:
77
- py-data-juicer
8+
- agentscope
89
- flask
910
- omegaconf
1011
- sqlalchemy
1112
- psycopg2
1213
- networkx
1314
- transformers
15+
- "-e ..[dev]"

environments/env_mapping.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,10 @@
33
"env_name": "trinity_data",
44
"env_yaml": "environments/data.yaml",
55
"env_entry": "trinity/data/server.py"
6+
},
7+
"trinity.training": {
8+
"env_name": "trinity",
9+
"env_yaml": "environments/training.yaml",
10+
"env_entry": "trinity/cli/server.py"
611
}
712
}

environments/training.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
name: trinity
2+
channels:
3+
- defaults
4+
dependencies:
5+
- python=3.10
6+
- pip:
7+
- "-e ..[dev]"

scripts/install.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@ def main():
2424
env_mapping = json.load(f)
2525
for env_path, env_config in env_mapping.items():
2626
env_name = env_config["env_name"]
27-
print(f"Installing dependencies for module {env_name}...")
27+
print(f"Installing dependencies for module [{env_name}]...")
2828
# check if it's existing
2929
res = subprocess.run(
3030
f"{env_mng} env list | grep {env_name}", shell=True, text=True, stdout=subprocess.PIPE
3131
)
3232
if res.returncode == 0 and env_name in res.stdout:
33-
print(f"Environment {env_name} already exists. Skipping...")
33+
print(f"Environment [{env_name}] already exists. Skipping...")
3434
else:
3535
res = subprocess.run(
3636
f'{env_mng} env create -f {env_config["env_yaml"]}'
@@ -39,9 +39,9 @@ def main():
3939
shell=True,
4040
)
4141
if res.returncode == 0:
42-
print(f"Environment {env_name} created successfully.")
42+
print(f"Environment [{env_name}] created successfully.")
4343
else:
44-
print(f"Failed to create environment {env_name} with exit code {res.returncode}.")
44+
print(f"Failed to create environment [{env_name}] with exit code {res.returncode}.")
4545

4646

4747
if __name__ == "__main__":

scripts/start_servers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def main():
2828
env_mapping = json.load(f)
2929
for env_path, env_config in env_mapping.items():
3030
env_name = env_config["env_name"]
31-
print(f"Starting server for module {env_name}...")
31+
print(f"Starting server for module [{env_name}]...")
3232
timestamp = time.strftime("%Y%m%d%H%M%S", time.localtime(time.time()))
3333
with open(os.path.join(args.log_dir, f"{env_name}_{timestamp}_log.txt"), "w") as log_file:
3434
server = subprocess.Popen(
@@ -38,7 +38,7 @@ def main():
3838
shell=True,
3939
)
4040
servers.append(server)
41-
print(f"Server of module {env_name} is started with PID {server.pid}")
41+
print(f"Server of module [{env_name}] is started with PID {server.pid}")
4242
for server in servers:
4343
server.wait()
4444

trinity/cli/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
LOCAL_TRINITY_TRAINING_SERVER_URL = "http://127.0.0.1:5006/trinity_training"
55

66

7-
def send_get_request(url: str, params: dict) -> None:
7+
def send_get_request(url: str, params: dict):
88
"""
99
Send GET request with parameters.
1010

trinity/data/core/dataset_db.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from trinity.common.config import DataConfig
99
from trinity.common.schema import Base, RftDatasetModel
1010
from trinity.data.core.dataset import RftDataset
11-
from trinity.manager.sql_storage import retry_session
11+
from trinity.buffer.utils import retry_session
1212
from trinity.utils.log import get_logger
1313

1414
logger = get_logger(__name__)

0 commit comments

Comments
 (0)