Add better metric display for dynamic sampling

[garyzhang99]

Description

The original implementation will only show the average skip_count as repeat_nums.

And will not show filtered_count in the monitor.

Now we modify this with a better display:

Checklist

Please check the following items before code is ready to be reviewed.

• Code has passed all tests
• Docstrings have been added/updated in Google Style
• Documentation has been updated
• Code is ready for review

[gemini-code-assist]

Summary of Changes

Hello @garyzhang99, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the monitoring of dynamic sampling by enhancing the granularity and clarity of reported metrics. It renames an existing metric for better context, introduces new metrics to reflect reward distribution, and ensures that the overall filtered_count accurately reflects the skipped experiences, providing a more comprehensive view of the sampling process.

Highlights

• Metric Renaming: The skipped_count metric has been renamed to skipped_count_per_group for better clarity and context within the dynamic sampling process.
• New Reward Metrics: Two new metrics, all_positive_reward_percentage and all_negative_reward_percentage, have been introduced to provide more detailed insights into the distribution of rewards within experience groups.
• Improved filtered_count Calculation: The filtered_count metric now accurately aggregates the newly named skipped_count_per_group values, ensuring correct reporting of filtered experiences.
• Code Refactoring: The conditional logic for handling group skipping and updating reward statistics has been refactored for conciseness and improved readability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves the metric display for dynamic sampling by renaming skipped_count to skipped_count_per_group for better clarity and introducing new metrics to monitor group reward characteristics. The changes are a good step forward. I've identified a potential bug regarding inconsistent metric reporting and a suggestion to improve the naming of the new metrics for better readability and maintainability.