Skip to content

Conversation

@hiyuchang
Copy link
Collaborator

@hiyuchang hiyuchang commented Nov 3, 2025

Description

As the title says.

image

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hiyuchang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates MLflow's system metrics logging feature into the project. By activating this functionality, the system will automatically capture and record crucial performance metrics such as CPU and memory usage during MLflow experiments, offering a more complete operational context for model development and analysis.

Highlights

  • MLflow System Metrics: Enabled automatic recording of system metrics (e.g., CPU, memory, disk I/O) for MLflow runs by calling mlflow.enable_system_metrics_logging().
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables system metrics recording for MLflow. While the feature is useful, the current implementation enables it globally at the module import level, which can cause unintended side effects for users of the library who may not be using the MlflowMonitor. My review suggests moving this logic into the MlflowMonitor's initializer to scope the behavior correctly and make it active only when the MLflow monitor is explicitly used.

@hiyuchang hiyuchang force-pushed the feat/mlflow_system_metrics branch from c2e29a3 to 20769c2 Compare November 3, 2025 03:39
@pan-x-c pan-x-c merged commit 3343729 into agentscope-ai:main Nov 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants