Skip to content

Async model support OpenAI compatible API #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pan-x-c merged 9 commits into from
May 21, 2025
Merged

Async model support OpenAI compatible API #41

pan-x-c merged 9 commits into from
May 21, 2025

Conversation

@pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented May 20, 2025 •
edited
Loading

Description

  1. Run OpenAI-compatible API server in vLLM async model ray actor
  2. Make ModelWrapper compatible with OpenAI
  3. Support reward model using the API server

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@pan-x-c pan-x-c changed the title [WIP] Async model support OpenAI compitable API [WIP] Async model support OpenAI compatible API May 20, 2025
@pan-x-c
Copy link
Collaborator Author

pan-x-c commented May 20, 2025

/run-unittest

@pan-x-c pan-x-c changed the title [WIP] Async model support OpenAI compatible API Async model support OpenAI compatible API May 20, 2025
@github-actions
Copy link

github-actions bot commented May 20, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
23 20 3 0 0 0 0 594ms

Failed Tests

Failed Tests ❌ Fail Message
❌ tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate The test failed in the call phase
❌ tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate The test failed in the call phase
❌ tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool The test failed in the call phase due to an assertion error

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer ✅ 4ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer ✅ 1ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid ✅ 1ms
tests/common/config_test.py::TestConfig::test_load_default_config ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion ✅ 1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate ✅ 44ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate ✅ 43ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate ❌ 1ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate ❌ 1ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate ✅ 39ms
tests/common/vllm_test.py::TestAPIServer::test_api ✅ 22ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask ✅ 1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer ✅ 1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer ✅ 99ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer ✅ 97ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool ❌ 3ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow ✅ 1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer ✅ 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer ✅ 230ms

Github Test Reporter by CTRF 💚

@pan-x-c
Copy link
Collaborator Author

pan-x-c commented May 21, 2025

/run-unittests

@github-actions
Copy link

github-actions bot commented May 21, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
23 21 2 0 0 0 0 614ms

Failed Tests

Failed Tests ❌ Fail Message
❌ tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate The test failed in the call phase
❌ tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate The test failed in the call phase

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer ✅ 4ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer ✅ 1ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid ✅ 1ms
tests/common/config_test.py::TestConfig::test_load_default_config ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion ✅ 1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate ✅ 45ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate ✅ 43ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate ❌ 1ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate ❌ 1ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate ✅ 38ms
tests/common/vllm_test.py::TestAPIServer::test_api ✅ 22ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask ✅ 1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer ✅ 1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer ✅ 94ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer ✅ 94ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool ✅ 19ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow ✅ 1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer ✅ 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer ✅ 242ms

Github Test Reporter by CTRF 💚

hiyuchang
hiyuchang reviewed May 21, 2025
View reviewed changes
@pan-x-c
Copy link
Collaborator Author

pan-x-c commented May 21, 2025

/run-unittest

chenyushuo
chenyushuo reviewed May 21, 2025
View reviewed changes
chenyushuo
chenyushuo reviewed May 21, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented May 21, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
23 23 0 0 0 0 0 738ms

Failed Tests

No failed tests ✨

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer ✅ 4ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer ✅ 1ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid ✅ 1ms
tests/common/config_test.py::TestConfig::test_load_default_config ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion ✅ 1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate ✅ 45ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate ✅ 43ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate ✅ 51ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate ✅ 53ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate ✅ 38ms
tests/common/vllm_test.py::TestAPIServer::test_api ✅ 21ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask ✅ 1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer ✅ 1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer ✅ 106ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer ✅ 109ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool ✅ 19ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow ✅ 1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer ✅ 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer ✅ 237ms

Github Test Reporter by CTRF 💚

@chenyushuo
Copy link
Collaborator

chenyushuo commented May 21, 2025

LGTM

@pan-x-c pan-x-c merged commit e3e1ad1 into modelscope:main May 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hiyuchang hiyuchang hiyuchang left review comments

@chenyushuo chenyushuo chenyushuo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pan-x-c @chenyushuo @hiyuchang