Skip to content

Commit 0855df7

Browse files
slin000111Jintao-Huang
authored andcommitted
Fix output_dir nesting during swift web_ui training (#513)
1 parent 0c81b2f commit 0855df7

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

swift/ui/llm_train/llm_train.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,14 @@ def do_build_ui(cls, base_tab: Type['BaseUI']):
243243
if not isinstance(value, (Tab, Accordion))
244244
] + [cls.element('log')] + Runtime.all_plots,
245245
cancels=Runtime.log_event)
246+
Runtime.element('kill_task').click(
247+
Runtime.kill_task,
248+
[Runtime.element('running_tasks')],
249+
[Runtime.element('running_tasks')]
250+
+ [Runtime.element('log')] + Runtime.all_plots,
251+
cancels=[Runtime.log_event],
252+
).then(Runtime.reset, [], [Runtime.element('logging_dir')]
253+
+ [Save.element('output_dir')])
246254

247255
@classmethod
248256
def update_runtime(cls):

swift/ui/llm_train/runtime.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -248,14 +248,6 @@ def do_build_ui(cls, base_tab: Type['BaseUI']):
248248
[base_tab.element('running_tasks')],
249249
)
250250

251-
base_tab.element('kill_task').click(
252-
Runtime.kill_task,
253-
[base_tab.element('running_tasks')],
254-
[base_tab.element('running_tasks')] + [cls.element('log')]
255-
+ cls.all_plots,
256-
cancels=[cls.log_event],
257-
)
258-
259251
@classmethod
260252
def update_log(cls):
261253
return [gr.update(visible=True)] * (len(Runtime.sft_plot) + 1)
@@ -411,6 +403,10 @@ def kill_task(task):
411403
return [Runtime.refresh_tasks()] + [gr.update(value=None)] * (
412404
len(Runtime.sft_plot) + 1)
413405

406+
@staticmethod
407+
def reset():
408+
return None, 'output'
409+
414410
@staticmethod
415411
def task_changed(task, base_tab):
416412
if task:

0 commit comments

Comments
 (0)