Skip to content

Commit 5ff8d5b

Browse files
authored
[bugfix] fix grpoargs check server_base_url (#5483)
* fix server check * fix
1 parent 5334b84 commit 5ff8d5b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

swift/llm/argument/rlhf_args.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -213,10 +213,10 @@ def _init_grpo(self):
213213
logger.info(f'Auto-configured soft_max_length = max_completion_length {self.max_completion_length}')
214214
if self.use_vllm:
215215
# set vllm mode
216-
if self.vllm_server_host is not None:
216+
if self.vllm_server_host is not None or self.vllm_server_base_url is not None:
217217
if self.vllm_mode != 'server':
218218
self.vllm_mode = 'server'
219-
logger.warning('set vllm_mode to `server` since vllm_server_host is provided')
219+
logger.warning('set vllm_mode to `server` since vllm server host/base_url is provided')
220220
else:
221221
if self.vllm_mode != 'colocate':
222222
self.vllm_mode = 'colocate'
@@ -253,7 +253,7 @@ def _init_rm(self):
253253
self.num_labels = 1
254254

255255
def _init_external_vllm(self):
256-
if self.rlhf_type != 'grpo' or self.vllm_server_host is None:
256+
if self.rlhf_type != 'grpo' or (self.vllm_server_host is None and self.vllm_server_base_url is None):
257257
return
258258
from swift.trainers.rlhf_trainer.vllm_client import VLLMClient
259259
if is_master():
@@ -313,7 +313,7 @@ def _check_grpo(self):
313313
assert is_liger_kernel_available(), (
314314
'Please install/update liger-kernel by running: pip install -U liger-kernel')
315315
if self.vllm_mode == 'server':
316-
assert not self.use_vllm or self.vllm_server_host is not None
316+
assert not self.use_vllm or self.vllm_server_host is not None or self.vllm_server_base_url is not None
317317

318318
if self.async_generate:
319319
assert self.vllm_mode == 'server', 'async generate require vllm_mode == server, '

0 commit comments

Comments
 (0)