Skip to content

Commit c7be303

Browse files
hjh0119Jintao-Huang
authored andcommitted
[bugfix] fix grpoargs check server_base_url (#5483)
* fix server check * fix
1 parent d71bf6b commit c7be303

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

swift/llm/argument/rlhf_args.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -210,10 +210,10 @@ def _init_grpo(self):
210210
logger.info(f'Auto-configured soft_max_length = max_completion_length {self.max_completion_length}')
211211
if self.use_vllm:
212212
# set vllm mode
213-
if self.vllm_server_host is not None:
213+
if self.vllm_server_host is not None or self.vllm_server_base_url is not None:
214214
if self.vllm_mode != 'server':
215215
self.vllm_mode = 'server'
216-
logger.warning('set vllm_mode to `server` since vllm_server_host is provided')
216+
logger.warning('set vllm_mode to `server` since vllm server host/base_url is provided')
217217
else:
218218
if self.vllm_mode != 'colocate':
219219
self.vllm_mode = 'colocate'
@@ -250,7 +250,7 @@ def _init_rm(self):
250250
self.num_labels = 1
251251

252252
def _init_external_vllm(self):
253-
if self.rlhf_type != 'grpo' or self.vllm_server_host is None:
253+
if self.rlhf_type != 'grpo' or (self.vllm_server_host is None and self.vllm_server_base_url is None):
254254
return
255255
from swift.trainers.rlhf_trainer.vllm_client import VLLMClient
256256
if is_master():
@@ -310,7 +310,7 @@ def _check_grpo(self):
310310
assert is_liger_kernel_available(), (
311311
'Please install/update liger-kernel by running: pip install -U liger-kernel')
312312
if self.vllm_mode == 'server':
313-
assert not self.use_vllm or self.vllm_server_host is not None
313+
assert not self.use_vllm or self.vllm_server_host is not None or self.vllm_server_base_url is not None
314314

315315
if self.async_generate:
316316
assert self.vllm_mode == 'server', 'async generate require vllm_mode == server, '

0 commit comments

Comments
 (0)