add autocommit to fix not saved data

Author: lesnik512

Justfile

@@ -12,6 +12,10 @@ sh:
 test *args: down && down
     docker compose run application sh -c "sleep 1 && uv run alembic downgrade base && uv run alembic upgrade head && uv run pytest {{ args }}"
 
+# run api
+run:
+    docker compose run --service-ports application sh -c "sleep 1 && uv run alembic upgrade head && uv run python -m app"
+
 # create alembic migration with arguments
 migration *args: && down
     docker compose run application sh -c "sleep 1 && uv run alembic upgrade head && uv run alembic revision --autogenerate {{ args }}"

app/application.py

@@ -3,7 +3,7 @@
 
 import fastapi
 import modern_di_fastapi
-from advanced_alchemy.exceptions import DuplicateKeyError, ForeignKeyError
+from advanced_alchemy.exceptions import DuplicateKeyError
 
 from app import exceptions, ioc
 from app.api.decks import ROUTER
@@ -23,13 +23,9 @@ def __init__(self) -> None:
         )
         self.di_container = modern_di_fastapi.setup_di(self.app)
         include_routers(self.app)
-        self.app.add_exception_handler(
-            ForeignKeyError,
-            exceptions.foreign_key_error_handler,  # type: ignore[arg-type]
-        )
         self.app.add_exception_handler(
             DuplicateKeyError,
-            exceptions.foreign_key_error_handler,  # type: ignore[arg-type]
+            exceptions.duplicate_key_error_handler,  # type: ignore[arg-type]
         )
 
     @contextlib.asynccontextmanager

app/exceptions.py

@@ -1,10 +1,10 @@
-from advanced_alchemy.exceptions import DuplicateKeyError, ForeignKeyError
+from advanced_alchemy.exceptions import DuplicateKeyError
 from fastapi.responses import JSONResponse
 from starlette import status
 from starlette.requests import Request
 
 
-async def foreign_key_error_handler(_: Request, exc: ForeignKeyError | DuplicateKeyError) -> JSONResponse:
+async def duplicate_key_error_handler(_: Request, exc: DuplicateKeyError) -> JSONResponse:
     return JSONResponse(
         status_code=status.HTTP_422_UNPROCESSABLE_ENTITY,
         content={"detail": exc.detail},

app/ioc.py

@@ -8,5 +8,5 @@ class Dependencies(BaseGraph):
     database_engine = providers.Resource(Scope.APP, create_sa_engine)
     session = providers.Resource(Scope.REQUEST, create_session, engine=database_engine.cast)
 
-    decks_service = providers.Factory(Scope.REQUEST, repositories.DecksService, session=session.cast)
-    cards_service = providers.Factory(Scope.REQUEST, repositories.CardsService, session=session.cast)
+    decks_service = providers.Factory(Scope.REQUEST, repositories.DecksService, session=session.cast, auto_commit=True)
+    cards_service = providers.Factory(Scope.REQUEST, repositories.CardsService, session=session.cast, auto_commit=True)

app/resources/db.py

@@ -10,7 +10,7 @@
 
 
 async def create_sa_engine() -> typing.AsyncIterator[sa.AsyncEngine]:
-    logger.debug("Initializing SQLAlchemy engine")
+    logger.info("Initializing SQLAlchemy engine")
     engine = sa.create_async_engine(
         url=settings.db_dsn,
         echo=settings.debug,
@@ -19,12 +19,12 @@ async def create_sa_engine() -> typing.AsyncIterator[sa.AsyncEngine]:
         pool_pre_ping=settings.db_pool_pre_ping,
         max_overflow=settings.db_max_overflow,
     )
-    logger.debug("SQLAlchemy engine has been initialized")
+    logger.info("SQLAlchemy engine has been initialized")
     try:
         yield engine
     finally:
         await engine.dispose()
-        logger.debug("SQLAlchemy engine has been cleaned up")
+        logger.info("SQLAlchemy engine has been cleaned up")
 
 
 class CustomAsyncSession(sa.AsyncSession):
@@ -37,4 +37,6 @@ async def close(self) -> None:
 
 async def create_session(engine: sa.AsyncEngine) -> typing.AsyncIterator[sa.AsyncSession]:
     async with CustomAsyncSession(engine, expire_on_commit=False, autoflush=False) as session:
+        logger.info("session created")
         yield session
+        logger.info("session closed")

tests/conftest.py

@@ -1,6 +1,5 @@
 import typing
 
-import modern_di
 import modern_di_fastapi
 import pytest
 from httpx import ASGITransport, AsyncClient
@@ -20,13 +19,8 @@ async def client() -> typing.AsyncIterator[AsyncClient]:
 
 
 @pytest.fixture(autouse=True)
-async def di_container() -> modern_di.Container:
-    return modern_di_fastapi.fetch_di_container(application)
-
-
-@pytest.fixture(autouse=True)
-async def db_session(di_container: modern_di.Container) -> typing.AsyncIterator[AsyncSession]:
-    async with di_container:
+async def db_session() -> typing.AsyncIterator[AsyncSession]:
+    async with modern_di_fastapi.fetch_di_container(application) as di_container:
         engine = await ioc.Dependencies.database_engine.async_resolve(di_container)
         connection = await engine.connect()
         transaction = await connection.begin()
@@ -39,3 +33,4 @@ async def db_session(di_container: modern_di.Container) -> typing.AsyncIterator[
             if connection.in_transaction():
                 await transaction.rollback()
             await connection.close()
+            await engine.dispose()