fix(rollup-plugin-html): properly exclude paths stating with ./

Author: bashmish

packages/rollup-plugin-html/src/assets/utils.ts

@@ -1,5 +1,6 @@
 import { Document, Element } from 'parse5';
 import path from 'path';
+import picomatch from 'picomatch';
 import { findElements, getTagName, getAttribute } from '@web/parse5-utils';
 import { createError } from '../utils.js';
 import { serialize } from 'v8';
@@ -143,3 +144,11 @@ export function getSourcePaths(node: Element) {
 export function findAssets(document: Document) {
   return findElements(document, isAsset);
 }
+
+// picomatch follows glob spec and requires "./" to be removed for the matcher to work
+// it is safe, because with or without it resolves to the same file
+// read more: https://github.com/micromatch/picomatch/issues/77
+const removeLeadingSlash = (str: string) => (str.startsWith('./') ? str.slice(2) : str);
+export function createAssetPicomatchMatcher(glob?: string | string[]) {
+  return picomatch(glob || [], { format: removeLeadingSlash });
+}

packages/rollup-plugin-html/src/input/extract/extractAssets.ts

@@ -1,13 +1,13 @@
 import { Document, serialize } from 'parse5';
 import fs from 'fs';
 import path from 'path';
-import picomatch from 'picomatch';
 import { InputAsset } from '../InputData.js';
 import {
   findAssets,
   getSourcePaths,
   isHashedAsset,
   resolveAssetFilePath,
+  createAssetPicomatchMatcher,
 } from '../../assets/utils.js';
 
 export interface ExtractAssetsParams {
@@ -22,7 +22,7 @@ export interface ExtractAssetsParams {
 export function extractAssets(params: ExtractAssetsParams): InputAsset[] {
   const assetNodes = findAssets(params.document);
   const allAssets: InputAsset[] = [];
-  const isExternal = picomatch(params.externalAssets || []);
+  const isExternal = createAssetPicomatchMatcher(params.externalAssets);
 
   for (const node of assetNodes) {
     const sourcePaths = getSourcePaths(node);

packages/rollup-plugin-html/src/output/injectedUpdatedAssetPaths.ts

@@ -1,14 +1,14 @@
 import { getAttribute, setAttribute } from '@web/parse5-utils';
 import { Document } from 'parse5';
 import path from 'path';
-import picomatch from 'picomatch';
 
 import {
   findAssets,
   getSourceAttribute,
   getSourcePaths,
   isHashedAsset,
   resolveAssetFilePath,
+  createAssetPicomatchMatcher,
 } from '../assets/utils.js';
 import { InputData } from '../input/InputData.js';
 import { createError } from '../utils.js';
@@ -49,7 +49,7 @@ export function injectedUpdatedAssetPaths(args: InjectUpdatedAssetPathsArgs) {
     absolutePathPrefix,
   } = args;
   const assetNodes = findAssets(document);
-  const isExternal = picomatch(externalAssets || []);
+  const isExternal = createAssetPicomatchMatcher(externalAssets);
 
   for (const node of assetNodes) {
     const sourcePaths = getSourcePaths(node);