Skip to content

Commit b4a1cff

Browse files
authored
Merge pull request #2239 from koddsson/update-webdriver
Update `webdriver` to version 8
2 parents 054b8ea + 812400a commit b4a1cff

File tree

7 files changed

+160
-177
lines changed

7 files changed

+160
-177
lines changed

.changeset/gold-poems-refuse.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@web/test-runner-saucelabs': minor
3+
'@web/test-runner-webdriver': minor
4+
---
5+
6+
Update `webdriver` to version 8

packages/test-runner-saucelabs/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@
4949
"ip": "^1.1.5",
5050
"nanoid": "^3.1.25",
5151
"saucelabs": "^7.2.0",
52-
"webdriver": "^7.16.0",
53-
"webdriverio": "^7.16.0"
52+
"webdriver": "^8.8.6",
53+
"webdriverio": "^8.8.6"
5454
},
5555
"devDependencies": {
5656
"@types/ip": "^1.1.0",

packages/test-runner-webdriver/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
],
4949
"dependencies": {
5050
"@web/test-runner-core": "^0.11.0",
51-
"webdriverio": "^7.16.0"
51+
"webdriverio": "^8.8.6"
5252
},
5353
"devDependencies": {
5454
"@types/selenium-standalone": "^7.0.1",

packages/test-runner-webdriver/src/IFrameManager.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { validateBrowserResult } from './coverage';
77
*/
88
export class IFrameManager {
99
private config: TestRunnerCoreConfig;
10-
private driver: Browser<'async'>;
10+
private driver: Browser;
1111
private framePerSession = new Map<string, string>();
1212
private inactiveFrames: string[] = [];
1313
private frameCount = 0;
@@ -16,7 +16,7 @@ export class IFrameManager {
1616
private locked?: Promise<unknown>;
1717
private isIE: boolean;
1818

19-
constructor(config: TestRunnerCoreConfig, driver: Browser<'async'>, isIE: boolean) {
19+
constructor(config: TestRunnerCoreConfig, driver: Browser, isIE: boolean) {
2020
this.config = config;
2121
this.driver = driver;
2222
this.isIE = isIE;
@@ -169,7 +169,7 @@ export class IFrameManager {
169169

170170
await this.driver.switchToFrame(frame);
171171

172-
const elementData = (await this.driver.execute(locator, [])) as Element<'async'>;
172+
const elementData = (await this.driver.execute(locator, [])) as Element;
173173

174174
const element = await this.driver.$(elementData);
175175

packages/test-runner-webdriver/src/SessionManager.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ import { validateBrowserResult } from './coverage';
77
*/
88
export class SessionManager {
99
private config: TestRunnerCoreConfig;
10-
private driver: Browser<'async'>;
10+
private driver: Browser;
1111
private locked?: Promise<unknown>;
1212
private isIE: boolean;
1313
private urlMap = new Map<string, string>();
1414

15-
constructor(config: TestRunnerCoreConfig, driver: Browser<'async'>, isIE: boolean) {
15+
constructor(config: TestRunnerCoreConfig, driver: Browser, isIE: boolean) {
1616
this.config = config;
1717
this.driver = driver;
1818
this.isIE = isIE;
@@ -89,7 +89,7 @@ export class SessionManager {
8989
}
9090

9191
async takeScreenshot(_: string, locator: string): Promise<Buffer> {
92-
const elementData = (await this.driver.execute(locator, [])) as Element<'async'>;
92+
const elementData = (await this.driver.execute(locator, [])) as Element;
9393

9494
const element = await this.driver.$(elementData);
9595

packages/test-runner-webdriver/src/webdriverLauncher.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ export class WebdriverLauncher implements BrowserLauncher {
2121
public name = 'Initializing...';
2222
public type = 'webdriver';
2323
private config?: TestRunnerCoreConfig;
24-
private driver?: Browser<'async'>;
25-
private debugDriver: undefined | Browser<'async'> = undefined;
24+
private driver?: Browser;
25+
private debugDriver: undefined | Browser = undefined;
2626
private driverManager?: IFrameManager | SessionManager;
2727
private __managerPromise?: Promise<IFrameManager | SessionManager>;
2828
private isIE = false;
@@ -82,7 +82,7 @@ export class WebdriverLauncher implements BrowserLauncher {
8282
if (this.debugDriver) {
8383
await this.debugDriver.deleteSession();
8484
}
85-
this.debugDriver = (await remote(this.options)) as Browser<'async'>;
85+
this.debugDriver = (await remote(this.options)) as Browser;
8686
await this.debugDriver.navigateTo(url);
8787
}
8888

@@ -106,7 +106,7 @@ export class WebdriverLauncher implements BrowserLauncher {
106106
const options: RemoteOptions = { logLevel: 'error', ...this.options };
107107

108108
try {
109-
this.driver = (await remote(options)) as Browser<'async'>;
109+
this.driver = (await remote(options)) as Browser;
110110
this.driverManager =
111111
this.config.concurrency === 1
112112
? new SessionManager(this.config, this.driver, this.isIE)

0 commit comments

Comments
 (0)