From 4e621ea1c2e1418123c569eb99a527da107cf362 Mon Sep 17 00:00:00 2001 From: Mikhail Bashkirov Date: Fri, 31 Jan 2025 17:17:02 +0100 Subject: [PATCH 1/4] chore: bump pipelines Ubuntu to latest 24.04 --- .github/workflows/canary.yml | 2 +- .github/workflows/lint.yml | 2 +- .github/workflows/release.yml | 2 +- .github/workflows/verify-browser.yml | 2 +- .github/workflows/verify-node.yml | 2 +- .github/workflows/verify-storybook-builder.yml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/canary.yml b/.github/workflows/canary.yml index a91cf1ff6..5df107dd5 100644 --- a/.github/workflows/canary.yml +++ b/.github/workflows/canary.yml @@ -12,7 +12,7 @@ jobs: # Prevents changesets action from creating a PR on forks if: github.repository == 'modernweb-dev/web' name: Pre-release - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 steps: - name: Checkout Repo uses: actions/checkout@v4 diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 2a803576d..03ec43ac5 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -9,7 +9,7 @@ jobs: linux: timeout-minutes: 30 name: Linux - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 3e855a188..75c4f52d3 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -11,7 +11,7 @@ jobs: # Prevents changesets action from creating a PR on forks if: github.repository == 'modernweb-dev/web' name: Release - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 steps: - name: Checkout Repo uses: actions/checkout@v4 diff --git a/.github/workflows/verify-browser.yml b/.github/workflows/verify-browser.yml index 5df8ff0bb..412d9689f 100644 --- a/.github/workflows/verify-browser.yml +++ b/.github/workflows/verify-browser.yml @@ -9,7 +9,7 @@ jobs: verify-linux: timeout-minutes: 30 name: Linux - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/verify-node.yml b/.github/workflows/verify-node.yml index 720af7b82..3f16b50e4 100644 --- a/.github/workflows/verify-node.yml +++ b/.github/workflows/verify-node.yml @@ -9,7 +9,7 @@ jobs: verify-linux: timeout-minutes: 30 name: Linux - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 strategy: fail-fast: false matrix: diff --git a/.github/workflows/verify-storybook-builder.yml b/.github/workflows/verify-storybook-builder.yml index 23884b46a..fef72d71e 100644 --- a/.github/workflows/verify-storybook-builder.yml +++ b/.github/workflows/verify-storybook-builder.yml @@ -7,7 +7,7 @@ jobs: strategy: fail-fast: false matrix: - runs-on: [ubuntu-22.04, windows-2022] + runs-on: [ubuntu-24.04, windows-2022] runs-on: ${{ matrix.runs-on }} name: ${{ matrix.runs-on }} timeout-minutes: 60 From ee36d0491a727102919aa71a5c31aec923658bd5 Mon Sep 17 00:00:00 2001 From: Mikhail Bashkirov Date: Mon, 3 Feb 2025 15:32:23 +0100 Subject: [PATCH 2/4] chore: workaround for Chrome sandbox in Ubuntu 24.04 --- .github/workflows/verify-browser.yml | 5 +++++ .github/workflows/verify-node.yml | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/.github/workflows/verify-browser.yml b/.github/workflows/verify-browser.yml index 412d9689f..73cf0e35a 100644 --- a/.github/workflows/verify-browser.yml +++ b/.github/workflows/verify-browser.yml @@ -14,6 +14,11 @@ jobs: steps: - uses: actions/checkout@v4 + # TODO: remove when GitHub fixes this https://github.com/actions/runner-images/issues/10015 + # (this workaround is practically the same what Playwright did in https://github.com/microsoft/playwright/pull/34238/files) + - name: Workaround for Chrome sandbox issue in Ubuntu 24.04 + run: sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0 + - name: Setup Node 20 uses: actions/setup-node@v4 env: diff --git a/.github/workflows/verify-node.yml b/.github/workflows/verify-node.yml index 3f16b50e4..be84efabd 100644 --- a/.github/workflows/verify-node.yml +++ b/.github/workflows/verify-node.yml @@ -22,6 +22,11 @@ jobs: steps: - uses: actions/checkout@v4 + # TODO: remove when GitHub fixes this https://github.com/actions/runner-images/issues/10015 + # (this workaround is practically the same what Playwright did in https://github.com/microsoft/playwright/pull/34238/files) + - name: Workaround for Chrome sandbox issue in Ubuntu 24.04 + run: sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0 + - name: Setup Node ${{ matrix.node-version }} uses: actions/setup-node@v4 env: From 0260bc770bd48cccc7af26e5e17c35e53ed1e38d Mon Sep 17 00:00:00 2001 From: Mikhail Bashkirov Date: Fri, 31 Jan 2025 17:30:51 +0100 Subject: [PATCH 3/4] chore: bump playwright version to latest which works in GitHub Actions Ubuntu 24.04 --- package-lock.json | 41 +++++++++---------- .../package.json | 2 +- packages/test-runner-playwright/package.json | 2 +- 3 files changed, 22 insertions(+), 23 deletions(-) diff --git a/package-lock.json b/package-lock.json index 945c433f5..6b35ad3ea 100644 --- a/package-lock.json +++ b/package-lock.json @@ -4049,22 +4049,19 @@ } }, "node_modules/@playwright/test": { - "version": "1.36.1", - "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.36.1.tgz", - "integrity": "sha512-YK7yGWK0N3C2QInPU6iaf/L3N95dlGdbsezLya4n0ZCh3IL7VgPGxC6Gnznh9ApWdOmkJeleT2kMTcWPRZvzqg==", + "version": "1.53.0", + "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.53.0.tgz", + "integrity": "sha512-15hjKreZDcp7t6TL/7jkAo6Df5STZN09jGiv5dbP9A6vMVncXRqE7/B2SncsyOwrkZRBH2i6/TPOL8BVmm3c7w==", "dev": true, + "license": "Apache-2.0", "dependencies": { - "@types/node": "*", - "playwright-core": "1.36.1" + "playwright": "1.53.0" }, "bin": { "playwright": "cli.js" }, "engines": { - "node": ">=16" - }, - "optionalDependencies": { - "fsevents": "2.3.2" + "node": ">=18" } }, "node_modules/@pnpm/config.env-replace": { @@ -24868,31 +24865,33 @@ } }, "node_modules/playwright": { - "version": "1.36.1", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.36.1.tgz", - "integrity": "sha512-2ZqHpD0U0COKR8bqR3W5IkyIAAM0mT9FgGJB9xWCI1qAUkqLxJskA1ueeQOTH2Qfz3+oxdwwf2EzdOX+RkZmmQ==", - "hasInstallScript": true, + "version": "1.53.0", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.53.0.tgz", + "integrity": "sha512-ghGNnIEYZC4E+YtclRn4/p6oYbdPiASELBIYkBXfaTVKreQUYbMUYQDwS12a8F0/HtIjr/CkGjtwABeFPGcS4Q==", "license": "Apache-2.0", "dependencies": { - "playwright-core": "1.36.1" + "playwright-core": "1.53.0" }, "bin": { "playwright": "cli.js" }, "engines": { - "node": ">=16" + "node": ">=18" + }, + "optionalDependencies": { + "fsevents": "2.3.2" } }, "node_modules/playwright-core": { - "version": "1.36.1", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.36.1.tgz", - "integrity": "sha512-7+tmPuMcEW4xeCL9cp9KxmYpQYHKkyjwoXRnoeTowaeNat8PoBMk/HwCYhqkH2fRkshfKEOiVus/IhID2Pg8kg==", + "version": "1.53.0", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.53.0.tgz", + "integrity": "sha512-mGLg8m0pm4+mmtB7M89Xw/GSqoNC+twivl8ITteqvAndachozYe2ZA7srU6uleV1vEdAHYqjq+SV8SNxRRFYBw==", "license": "Apache-2.0", "bin": { "playwright-core": "cli.js" }, "engines": { - "node": ">=16" + "node": ">=18" } }, "node_modules/please-upgrade-node": { @@ -38070,7 +38069,7 @@ "@web/storybook-builder": "^0.2.2" }, "devDependencies": { - "@playwright/test": "^1.22.2", + "@playwright/test": "^1.53.0", "@storybook/addon-a11y": "^8.6.12", "@storybook/addon-essentials": "^8.6.12", "@storybook/addon-interactions": "^8.6.12", @@ -38540,7 +38539,7 @@ "dependencies": { "@web/test-runner-core": "^0.13.0", "@web/test-runner-coverage-v8": "^0.8.0", - "playwright": "^1.22.2" + "playwright": "^1.53.0" }, "devDependencies": { "@web/test-runner-mocha": "^0.9.0", diff --git a/packages/storybook-framework-web-components/package.json b/packages/storybook-framework-web-components/package.json index 2a9e7bf43..c39649f19 100644 --- a/packages/storybook-framework-web-components/package.json +++ b/packages/storybook-framework-web-components/package.json @@ -60,7 +60,7 @@ "@web/storybook-builder": "^0.2.2" }, "devDependencies": { - "@playwright/test": "^1.22.2", + "@playwright/test": "^1.53.0", "@storybook/addon-a11y": "^8.6.12", "@storybook/addon-essentials": "^8.6.12", "@storybook/addon-interactions": "^8.6.12", diff --git a/packages/test-runner-playwright/package.json b/packages/test-runner-playwright/package.json index 6521d591d..0ba889726 100644 --- a/packages/test-runner-playwright/package.json +++ b/packages/test-runner-playwright/package.json @@ -48,7 +48,7 @@ "dependencies": { "@web/test-runner-core": "^0.13.0", "@web/test-runner-coverage-v8": "^0.8.0", - "playwright": "^1.22.2" + "playwright": "^1.53.0" }, "devDependencies": { "@web/test-runner-mocha": "^0.9.0", From dbd6f474fa34a83c288194e08ccf58ccd301d5ec Mon Sep 17 00:00:00 2001 From: Mikhail Bashkirov Date: Wed, 11 Jun 2025 19:35:36 +0200 Subject: [PATCH 4/4] chore: release @web/test-runner-playwright with latest playwright --- .changeset/tidy-hairs-hope.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/tidy-hairs-hope.md diff --git a/.changeset/tidy-hairs-hope.md b/.changeset/tidy-hairs-hope.md new file mode 100644 index 000000000..4d382f5b2 --- /dev/null +++ b/.changeset/tidy-hairs-hope.md @@ -0,0 +1,5 @@ +--- +'@web/test-runner-playwright': patch +--- + +bump playwright