Skip to content

Conversation

bashmish
Copy link
Member

@bashmish bashmish commented Aug 7, 2025

What I did

  1. Manually set Node to 22.18 for storybook-builder tests (currently the default one used fro Node 22 was 22.17, so I had to be explicit to use a more recent one 22.18)

  2. Checked that it breaks with Node 22.18

image
  1. Fixed and checked that the fix works for Node 22.18
image
  1. Reverted back the pipeline to use default Node 22 (which today installs Node 22.17 until Actions update their default Node 22 to 22.18, which is fine for now I think)

Copy link

changeset-bot bot commented Aug 7, 2025

🦋 Changeset detected

Latest commit: 26fccca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/storybook-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bashmish bashmish force-pushed the fix/storybook-builder-with-node-22.18 branch from f852503 to 4518368 Compare August 7, 2025 20:30
@bashmish bashmish force-pushed the fix/storybook-builder-with-node-22.18 branch from 4518368 to cfcea9d Compare August 7, 2025 20:41
@bashmish bashmish merged commit 987a2c8 into master Aug 7, 2025
4 of 9 checks passed
@bashmish bashmish deleted the fix/storybook-builder-with-node-22.18 branch August 7, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant