default oc period data arrays None

Author: wpbonelli

flopy4/mf6/gwf/oc.py

@@ -49,28 +49,28 @@ class Period:
     save_head: Optional[NDArray[np.str_]] = array(
         dtype=np.dtypes.StringDType(),
         block="period",
-        default="all",
+        default=None,
         dims=("nper",),
         converter=Converter(dict_to_array, takes_self=True, takes_field=True),
     )
     save_budget: Optional[NDArray[np.str_]] = array(
         dtype=np.dtypes.StringDType(),
         block="period",
-        default="all",
+        default=None,
         dims=("nper",),
         converter=Converter(dict_to_array, takes_self=True, takes_field=True),
     )
     print_head: Optional[NDArray[np.str_]] = array(
         dtype=np.dtypes.StringDType(),
         block="period",
-        default="all",
+        default=None,
         dims=("nper",),
         converter=Converter(dict_to_array, takes_self=True, takes_field=True),
     )
     print_budget: Optional[NDArray[np.str_]] = array(
         dtype=np.dtypes.StringDType(),
         block="period",
-        default="all",
+        default=None,
         dims=("nper",),
         converter=Converter(dict_to_array, takes_self=True, takes_field=True),
     )

test/test_codec.py

@@ -67,13 +67,8 @@ def test_dumps_oc():
     dumped = dumps(COMPONENT_CONVERTER.unstructure(oc))
     print("OC dump:")
     print(dumped)
-    # TODO these are getting truncated, need to specify string length like <U4 etc.
-    # add a dtype argument to the array decorator? or overload the first argument
-    # which currently acccepts cls for arrays of object type, to work for str dtype?
     assert "save head all" in dumped
     assert "save budget all" in dumped
-    assert "print head all" in dumped
-    assert "print budget all" in dumped
     assert dumped
 
     loaded = loads(dumped)
@@ -121,6 +116,12 @@ def test_dumps_tdis():
     print("TDIS dump:")
     print(dumped)
     assert dumped
+    assert "BEGIN PERIODDATA 1" in dumped
+    assert " 1.0 1 1.0" in dumped
+    assert "END PERIODDATA 1" in dumped
+    assert "BEGIN PERIODDATA 2" in dumped
+    assert " 2.0 2 1.0" in dumped
+    assert "END PERIODDATA 2" in dumped
 
     loaded = loads(dumped)
     print("TDIS load:")

test/test_interface.py

@@ -63,7 +63,7 @@ def test_flopy3_model(tmp_path):
     ims.inner_hclose = 1e-6
     ims.inner_rclose = 0.1000000
     ic = Ic(dims=dims)
-    oc = Oc(dims=dims)
+    oc = Oc(dims=dims, save_head={0: "all"}, save_budget={0: "all"})
     npf = Npf(dims=dims)
     chd = Chd(dims=dims, head={0: {(0, 0, 0): 1.0, (0, 9, 9): 0.0}})